nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	Linux MM <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] dax: Change return type to vm_fault_t
Date: Mon, 16 Apr 2018 10:47:40 -0700	[thread overview]
Message-ID: <20180416174740.GA12686@bombadil.infradead.org> (raw)
In-Reply-To: <CAPcyv4g+Gdc2tJ1qrM5Xn9vtARw-ZqFXaMbiaBKJJsYDtSNBig@mail.gmail.com>

On Mon, Apr 16, 2018 at 09:14:48AM -0700, Dan Williams wrote:
> > -       rc = vm_insert_mixed(vmf->vma, vmf->address, pfn);
> > -
> > -       if (rc == -ENOMEM)
> > -               return VM_FAULT_OOM;
> > -       if (rc < 0 && rc != -EBUSY)
> > -               return VM_FAULT_SIGBUS;
> > -
> > -       return VM_FAULT_NOPAGE;
> > +       return vmf_insert_mixed(vmf->vma, vmf->address, pfn);
> 
> Ugh, so this change to vmf_insert_mixed() went upstream without fixing
> the users? This changelog is now misleading as it does not mention
> that is now an urgent standalone fix. On first read I assumed this was
> part of a wider effort for 4.18.

You read too quickly.  vmf_insert_mixed() is a *new* function which
*replaces* vm_insert_mixed() and
awful-mangling-of-return-values-done-per-driver.

Eventually vm_insert_mixed() will be deleted.  But today is not that day.

  parent reply	other threads:[~2018-04-16 17:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-14 15:50 [PATCH] dax: Change return type to vm_fault_t Souptick Joarder
2018-04-16 16:14 ` Dan Williams
2018-04-16 16:29   ` Randy Dunlap
2018-04-16 16:38     ` Souptick Joarder
2018-04-16 17:47   ` Matthew Wilcox [this message]
2018-04-16 18:00     ` Dan Williams
2018-04-16 18:21       ` Matthew Wilcox
2018-04-16 18:28         ` Souptick Joarder
2018-04-16 18:35           ` Dan Williams
2018-04-16 18:37             ` Souptick Joarder
2018-04-16 18:41               ` Randy Dunlap
2018-04-17  0:14   ` Theodore Y. Ts'o
2018-04-17  0:19     ` Matthew Wilcox
2018-04-17  4:08       ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416174740.GA12686@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).