From: Matthew Wilcox <willy@infradead.org>
To: David Rientjes <rientjes@google.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
Randy Dunlap <rdunlap@infradead.org>,
Souptick Joarder <jrdr.linux@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] dax: Change return type to vm_fault_t
Date: Fri, 27 Apr 2018 05:11:36 -0700 [thread overview]
Message-ID: <20180427121136.GB8161@bombadil.infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1804270135100.68707@chino.kir.corp.google.com>
On Fri, Apr 27, 2018 at 01:37:02AM -0700, David Rientjes wrote:
> On Fri, 27 Apr 2018, Souptick Joarder wrote:
>
> > Hi Matthew/ Ross,
> >
> > There are two changes exist in mm/huge_memory.c as part of this
> > patch. vmf_insert_pfn_pmd() and vmf_insert_pfn_pud() functions are
> > invoked from this patch.
> >
> > Shall we put both in a single patch that it will easy to bisect in case
> > we have any issue ?
> >
>
> Please put them into a single patch, there's no reason to convert
>
> int foo() -> vm_fault_t foo()
>
> but leave
>
> int bar()
> {
> return foo()
> }
>
> It would be best just to convert all callers to also return vm_fault_t as
> I outlined in my response.
Yes, they're all getting converted, but there are too many to do in a
single patch. So it's just a matter of how to split them up. Since the
types are compatible (for now), I advised Souptick to split them by
maintenance area in order to minimise conflicts with other patches.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-04-27 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 13:28 [PATCH v3] dax: Change return type to vm_fault_t Souptick Joarder
2018-04-27 5:59 ` Souptick Joarder
2018-04-27 8:37 ` David Rientjes
2018-04-27 12:11 ` Matthew Wilcox [this message]
2018-04-27 18:33 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427121136.GB8161@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-nvdimm@lists.01.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).