From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE446203BBBAA for ; Tue, 8 May 2018 10:44:26 -0700 (PDT) Date: Tue, 8 May 2018 11:44:24 -0600 From: Ross Zwisler Subject: Re: [PATCH 0/5] fix radix tree multi-order iteration race Message-ID: <20180508174424.GA12638@linux.intel.com> References: <20180503192430.7582-1-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180503192430.7582-1-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ross Zwisler Cc: Jan Kara , linux-nvdimm@lists.01.org, Dave Chinner , linux-kernel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , Andrew Morton List-ID: On Thu, May 03, 2018 at 01:24:25PM -0600, Ross Zwisler wrote: > The following series gets the radix tree test suite compiling again in > the current linux/master, adds a unit test which exposes a race in the > radix tree multi-order iteration code, and then fixes that race. > > This race was initially hit on a v4.15 based kernel and results in a GP > fault. I've described the race in detail in patches 4 and 5. > > The fix is simple and necessary, and I think it should be merged for > v4.17. > > This tree has gotten positive build confirmation from the 0-day bot, > passes the updated radix tree test suite, xfstests, and the original > test that was hitting the race with the v4.15 based kernel. > > Ross Zwisler (5): > radix tree test suite: fix mapshift build target > radix tree test suite: fix compilation issue > radix tree test suite: add item_delete_rcu() > radix tree test suite: multi-order iteration race > radix tree: fix multi-order iteration race > > lib/radix-tree.c | 6 ++-- > tools/include/linux/spinlock.h | 3 +- > tools/testing/radix-tree/Makefile | 6 ++-- > tools/testing/radix-tree/multiorder.c | 63 +++++++++++++++++++++++++++++++++++ > tools/testing/radix-tree/test.c | 19 +++++++++++ > tools/testing/radix-tree/test.h | 3 ++ > 6 files changed, 91 insertions(+), 9 deletions(-) > > -- > 2.14.3 > Ping on this series. Does anyone have any feedback? Matthew? I'd really like to get it into v4.17. We can take it through the libnvdimm tree, if that's easiest. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm