From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Cornelia Huck <cohuck@redhat.com>,
Qemu Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check"
Date: Fri, 8 Jun 2018 02:14:31 +0300 [thread overview]
Message-ID: <20180608021134-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180607223111.27792-3-ross.zwisler@linux.intel.com>
On Thu, Jun 07, 2018 at 04:31:09PM -0600, Ross Zwisler wrote:
> This commit:
>
> commit aa78a16d8645 ("hw/i386: Rename 2.13 machine types to 3.0")
>
> updated the name used to create the q35 machine, which in turn changed the
> SSDT table which is generated when we run "make check":
>
> acpi-test: Warning! SSDT mismatch. Actual [asl:/tmp/asl-QZDWJZ.dsl,
> aml:/tmp/aml-T8JYJZ], Expected [asl:/tmp/asl-DTWVJZ.dsl,
> aml:tests/acpi-test-data/q35/SSDT.dimmpxm].
>
> Here's the only difference, aside from the checksum:
>
> < Name (MEMA, 0x07FFF000)
> ---
> > Name (MEMA, 0x07FFE000)
Weird. How come the phys address changes just because of machine name?
>
> Update the binary table that we compare against so it reflects this name
> change.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Fixes: commit aa78a16d8645 ("hw/i386: Rename 2.13 machine types to 3.0")
> ---
> tests/acpi-test-data/q35/SSDT.dimmpxm | Bin 685 -> 685 bytes
> 1 file changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/tests/acpi-test-data/q35/SSDT.dimmpxm b/tests/acpi-test-data/q35/SSDT.dimmpxm
> index 8ba0e67cb72daa81a65da4906d37a5e0f4af1fd4..2d5b721bcf9c398feb6d005761f898015042e8a4 100644
> GIT binary patch
> delta 23
> fcmZ3>x|WqIIM^j*EfWI+qr*n71x(Bz{<8xBPCEwk
>
> delta 23
> fcmZ3>x|WqIIM^j*EfWI+W57nP1x(Bj{<8xBPMZev
>
> --
> 2.14.4
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-06-07 23:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 22:31 [qemu PATCH 1/5] gitignore: ignore generated qapi job files Ross Zwisler
2018-06-07 22:31 ` [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch Ross Zwisler
2018-06-07 23:09 ` Michael S. Tsirkin
2018-06-08 5:17 ` [Qemu-devel] " Thomas Huth
2018-06-08 15:34 ` Ross Zwisler
2018-06-08 15:59 ` Michael S. Tsirkin
2018-06-08 16:14 ` Peter Maydell
2018-06-08 16:21 ` Michael S. Tsirkin
2018-06-08 16:03 ` Michael S. Tsirkin
2018-06-08 16:16 ` Peter Maydell
2018-06-08 16:24 ` Michael S. Tsirkin
2018-06-08 17:23 ` Thomas Huth
2018-06-08 18:41 ` Michael S. Tsirkin
2018-06-08 19:56 ` Thomas Huth
2018-06-07 22:31 ` [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check" Ross Zwisler
2018-06-07 23:14 ` Michael S. Tsirkin [this message]
2018-06-08 14:24 ` [Qemu-devel] " Eric Blake
2018-06-08 16:00 ` Michael S. Tsirkin
2018-06-08 5:39 ` Thomas Huth
2018-06-07 22:31 ` [qemu PATCH 4/5] machine: fix some misspelled words Ross Zwisler
2018-06-08 5:38 ` [Qemu-devel] " Thomas Huth
2018-06-08 17:41 ` Ross Zwisler
2018-06-08 18:01 ` Eric Blake
2018-06-07 22:31 ` [qemu PATCH 5/5] nvdimm: make persistence option symbolic Ross Zwisler
2018-06-08 19:34 ` Michael S. Tsirkin
2018-06-08 14:59 ` [qemu PATCH 1/5] gitignore: ignore generated qapi job files Eric Blake
2018-06-08 15:00 ` Eric Blake
2018-06-08 15:36 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608021134-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=linux-nvdimm@lists.01.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=ross.zwisler@linux.intel.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).