From: Keith Busch <keith.busch@intel.com>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCHv3 1/2] libnvdimm: Use max contiguous area for namespace size
Date: Fri, 20 Jul 2018 14:54:53 -0600 [thread overview]
Message-ID: <20180720205453.GA4864@localhost.localdomain> (raw)
In-Reply-To: <1532119565.10343.15.camel@intel.com>
On Fri, Jul 20, 2018 at 01:46:06PM -0700, Verma, Vishal L wrote:
>
> On Thu, 2018-07-12 at 09:47 -0600, Keith Busch wrote:
> > This patch will find the max contiguous area to determine the largest
> > pmem namespace size that can be created. If the requested size exceeds
> > the largest available, ENOSPC error will be returned.
> >
> > This fixes the allocation underrun error and wrong error return code
> > that have otherwise been observed as the following kernel warning:
> >
> > WARNING: CPU: <CPU> PID: <PID> at drivers/nvdimm/namespace_devs.c:913 size_store
> >
> > Fixes: a1f3e4d6a0c3 ("libnvdimm, region: update nd_region_available_dpa() for multi-pmem support")
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Keith Busch <keith.busch@intel.com>
>
> Hi Keith,
>
> I was testing these patches and I found:
>
> When booting a VM which has both, a qemu ACPI.NFIT bus, and nfit_test
> buses, initially the nfit_test buses show correct max_available_extent.
> But the qemu ACPI.NFIT bus regions (which have an automatic full-
> capacity namespace created on them when they come up) show
> max_available_extent of the full region size, even as the
> available_size attr is zero.
The max extents only counts the free pmem that it can reserve.
We shouldn't have been able to reserve non-free pmem, so it sounds like
something must be wrong with how the resources were set up.
I'll make a similar qemu config and see why/if the resource was
considered free.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-07-20 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 15:47 [PATCHv3 1/2] libnvdimm: Use max contiguous area for namespace size Keith Busch
2018-07-12 15:47 ` [PATCHv3 2/2] libnvdimm: Export max available extent Keith Busch
2018-07-20 20:46 ` [PATCHv3 1/2] libnvdimm: Use max contiguous area for namespace size Verma, Vishal L
2018-07-20 20:54 ` Keith Busch [this message]
2018-07-20 21:48 ` Keith Busch
2018-07-20 23:17 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720205453.GA4864@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=stable@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).