From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 02BC2210BFF7B for ; Sat, 21 Jul 2018 20:11:46 -0700 (PDT) Date: Sat, 21 Jul 2018 21:11:44 -0600 From: Ross Zwisler Subject: Re: [PATCH 1/5] radix tree test suite: fix mapshift build target Message-ID: <20180722031144.GA12948@linux.intel.com> References: <20180503192430.7582-1-ross.zwisler@linux.intel.com> <20180503192430.7582-2-ross.zwisler@linux.intel.com> <20180715230052.GA6486@bombadil.infradead.org> <20180716160710.GA2287@linux.intel.com> <20180716195249.GA14380@bombadil.infradead.org> <20180716210820.GA17164@linux.intel.com> <20180717024132.GC7934@bombadil.infradead.org> <20180721234550.GB1691@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180721234550.GB1691@dastard> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dave Chinner Cc: Jan Kara , kbuild test robot , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , kbuild-all@01.org, Andrew Morton List-ID: On Sun, Jul 22, 2018 at 09:45:50AM +1000, Dave Chinner wrote: > On Mon, Jul 16, 2018 at 07:41:32PM -0700, Matthew Wilcox wrote: > > On Mon, Jul 16, 2018 at 03:08:20PM -0600, Ross Zwisler wrote: > > > On Mon, Jul 16, 2018 at 12:52:49PM -0700, Matthew Wilcox wrote: > > > > On Mon, Jul 16, 2018 at 10:07:10AM -0600, Ross Zwisler wrote: > > > <> > > > > OK ... what version of make are you using? Because this works fine for me: > > > > > > > > $ git clone linux clean > > > > $ cd clean > > > > $ git checkout v4.17 > > > > $ cd tools/testing/radix-tree/ > > > > $ git revert 8d9fa88edd5e360b71765feeadb915d4066c9684 > > > > $ make > > > > > > > > $ make --version > > > > GNU Make 4.1 > > > > Built for x86_64-pc-linux-gnu > > > > > > > > It's Debian's Version: 4.1-9.1 > > > > > > $ make --version > > > GNU Make 4.2.1 > > > Built for x86_64-redhat-linux-gnu > > > > > > The one from Fedora 27. > > > > Huh. I just tried 4.2.1-1.1 from Debian unstable and that doesn't > > produce the problem either. I'm not sure how to proceed at this point. > > I'm really not a makefile expert. > > This smells like a problem we just hit with make 4.2.1 in fedora 28 > in fstests - the regex expanstion has been screwed up such that > things like [a-z] will match [A-Z] and other things as well. Debian > is unaffected, apparently fedora has a backport of stuff from the > as-yet-unreleased next version of make/glibc. See this thread: > > https://www.spinics.net/lists/fstests/msg10200.html > > Try setting LANG=C and seeing if the problem goes away.... Hey Dave, we root caused this difference to to be the fact that I had 'make' aliased to 'make -j32' in my .bashrc. Matthew was running a singled threaded build, while I was running a multi-threaded one. When Matthew ran a multi-threaded build, he was able to reproduce the issue. So, essentially I think that the makefile just needs to be enhanced so that all the dependencies are explicit to allow multi-threaded builds to work properly. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm