nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Huaisheng Ye <yehs2007@zoho.com>
Cc: axboe@kernel.dk, linux-s390@vger.kernel.org,
	linux-nvdimm@lists.01.org, chengnt@lenovo.com,
	linux-fsdevel@vger.kernel.org, heiko.carstens@de.ibm.com,
	linux-kernel@vger.kernel.org, willy@infradead.org,
	bart.vanassche@wdc.com, viro@zeniv.linux.org.uk,
	gregkh@linuxfoundation.org, schwidefsky@de.ibm.com, jack@suse.cz
Subject: Re: [PATCH 0/5] Do not request a pointer kaddr when not required
Date: Tue, 24 Jul 2018 08:50:13 -0600	[thread overview]
Message-ID: <20180724145013.GA19466@linux.intel.com> (raw)
In-Reply-To: <20180724084510.6104-1-yehs2007@zoho.com>

On Tue, Jul 24, 2018 at 04:45:05PM +0800, Huaisheng Ye wrote:
> From: Huaisheng Ye <yehs1@lenovo.com>
> Some functions within fs/dax and dax/super don't need to get kaddr from
> direct_access. Assigning NULL to kaddr to ->direct_access() is more
> straightforward and simple than offering a useless local pointer.
> So all direct_access() need to check the validity of second rank pointer
> kaddr for NULL assignment. If kaddr equals to NULL, it doesn't need to
> calculate its value.
> * This series are supplement to [PATCH v2 00/14]mm: Asynchronous +
>   multithreaded memmap init for ZONE_DEVICE. [1]
> [1]: https://lkml.org/lkml/2018/7/16/828

This whole series looks good to me.  Just a few comments:

1) Does this series actually depend on the "Asynchronous multithreaded mmap
init for ZONE_DEVICE" series from Dan?  It seems totally independent to me?
I reviewed yours by applying to linux/master, which worked fine.  I ask
because Dan's series has been delayed to after v4.19, and if yours isn't
actually dependent it could possibly go in sooner.

2) I agree with Christian's comment that the changelogs could be improved
slightly.  Remember that the goal of the changelog isn't to describe *what*
the code is doing, but *why*.  We can read that the code now checks if 'kaddr'
is NULL, and if so we don't calculate it.  It's useful to say that callers may
have no need for 'kaddr', so this patch is prep for allowing them to pass in
NULL instead of having to pass in a pointer that they then just throw away.

3) I think you should make one more change to kill the unused 'dummy_addr'
variable in persistent_memory_claim().  That was the one last case of a dummy
'kaddr' type variable that I could find.
Linux-nvdimm mailing list

  parent reply	other threads:[~2018-07-24 14:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24  8:45 [PATCH 0/5] Do not request a pointer kaddr when not required Huaisheng Ye
2018-07-24  8:45 ` [PATCH 1/5] libnvdimm, pmem: Allow a NULL-kaddr to ->direct_access() Huaisheng Ye
2018-07-24  8:45 ` [PATCH 2/5] tools/testing/nvdimm: " Huaisheng Ye
2018-07-24  8:45 ` [PATCH 3/5] s390, dcssblk: " Huaisheng Ye
2018-07-24  8:53   ` Christian Borntraeger
2018-07-24  9:46     ` [External] " Huaisheng HS1 Ye
2018-07-24 11:16       ` Christian Borntraeger
2018-07-24 14:28         ` Huaisheng HS1 Ye
2018-07-24  8:45 ` [PATCH 4/5] filesystem-dax: Do not request a pointer kaddr when not required Huaisheng Ye
2018-07-24  8:45 ` [PATCH 5/5] dax/super: " Huaisheng Ye
2018-07-24 14:50 ` Ross Zwisler [this message]
2018-07-24 15:41   ` [External] Re: [PATCH 0/5] " Huaisheng HS1 Ye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724145013.GA19466@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=chengnt@lenovo.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    --cc=yehs2007@zoho.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).