nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Huaisheng Ye <yehs2007@zoho.com>
Cc: jack@suse.cz, snitzer@redhat.com, heiko.carstens@de.ibm.com,
	dm-devel@redhat.com, agk@redhat.com, linux-s390@vger.kernel.org,
	linux-nvdimm@lists.01.org, willy@infradead.org,
	bart.vanassche@wdc.com, chengnt@lenovo.com, colyli@suse.de,
	schwidefsky@de.ibm.com, viro@zeniv.linux.org.uk, axboe@kernel.dk,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access()
Date: Wed, 25 Jul 2018 11:23:16 -0600	[thread overview]
Message-ID: <20180725172316.GA12896@linux.intel.com> (raw)
In-Reply-To: <20180725162849.8320-1-yehs2007@zoho.com>

On Thu, Jul 26, 2018 at 12:28:43AM +0800, Huaisheng Ye wrote:
> From: Huaisheng Ye <yehs1@lenovo.com>
> 
> Changes since v1 [1]:
> * Involve the previous patches for pfn can be NULL.
> * Reword the patch descriptions according to Christian's comment.
> * According to Ross's suggestion, replace local pointer dummy_addr
>   with NULL within md/dm-writecache for direct_access.
> 
> [1]: https://lkml.org/lkml/2018/7/24/199
> 
> Some functions within fs/dax, dax/super and md/dm-writecache don't
> need to get local pointer kaddr or variable pfn from direct_access.
> Assigning NULL to kaddr or pfn to ->direct_access() is more
> straightforward and simple than offering a useless local pointer or
> variable.
> 
> So all ->direct_access() need to check the validity of pointer kaddr
> and pfn for NULL assignment. If either of them is equal to NULL, that
> is to say callers may have no need for kaddr or pfn, so this series of
> patch are prepared for allowing them to pass in NULL instead of having
> to pass in a local pointer or variable that they then just throw away.

Looks good.  For the series:

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2018-07-25 17:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 16:28 [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access() Huaisheng Ye
2018-07-25 16:28 ` [PATCH v2 1/6] libnvdimm, pmem: " Huaisheng Ye
2018-07-25 16:28 ` [PATCH v2 2/6] s390, dcssblk: " Huaisheng Ye
2018-07-28  4:07   ` [External] " Huaisheng HS1 Ye
2018-07-30  5:14     ` Martin Schwidefsky
2018-07-25 16:28 ` [PATCH v2 3/6] tools/testing/nvdimm: " Huaisheng Ye
2018-07-25 16:28 ` [PATCH v2 4/6] dax/super: Do not request a pointer kaddr when not required Huaisheng Ye
2018-07-25 16:28 ` [PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy_addr " Huaisheng Ye
2018-07-27 19:33   ` Mike Snitzer
2018-07-25 16:28 ` [PATCH v2 6/6] filesystem-dax: Do not request kaddr and pfn " Huaisheng Ye
2018-07-25 17:23 ` Ross Zwisler [this message]
2018-07-25 21:35 ` [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access() Dave Jiang
2018-07-26  1:29   ` [External] " Huaisheng HS1 Ye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725172316.GA12896@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=chengnt@lenovo.com \
    --cc=colyli@suse.de \
    --cc=dm-devel@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=snitzer@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    --cc=yehs2007@zoho.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).