nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Masayoshi Mizuma <msys.mizuma@gmail.com>
To: linux-nvdimm@lists.01.org
Cc: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Subject: [PATCH] ndctl, monitor: Change the fail log priority to err.
Date: Wed,  1 Aug 2018 14:55:38 -0400	[thread overview]
Message-ID: <20180801185538.27084-1-msys.mizuma@gmail.com> (raw)

From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>

fail() is called if an error happens, but the log priority
is debug, so user may not notice the error.
Let's change the priority to err.

Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
 ndctl/monitor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ndctl/monitor.c b/ndctl/monitor.c
index 84d51c4..68bbf65 100644
--- a/ndctl/monitor.c
+++ b/ndctl/monitor.c
@@ -40,7 +40,7 @@ static int did_fail;
 #define fail(fmt, ...) \
 do { \
 	did_fail = 1; \
-	dbg(ctx, "ndctl-%s:%s:%d: " fmt, \
+	err(ctx, "ndctl-%s:%s:%d: " fmt, \
 			VERSION, __func__, __LINE__, ##__VA_ARGS__); \
 } while (0)

Linux-nvdimm mailing list

             reply	other threads:[~2018-08-01 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 18:55 Masayoshi Mizuma [this message]
2018-08-02 11:42 ` [PATCH] ndctl, monitor: Change the fail log priority to err Qi, Fuli
2018-08-02 13:10   ` Masayoshi Mizuma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801185538.27084-1-msys.mizuma@gmail.com \
    --to=msys.mizuma@gmail.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=m.mizuma@jp.fujitsu.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).