From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 45406210DF76B for ; Thu, 9 Aug 2018 01:59:42 -0700 (PDT) Date: Thu, 9 Aug 2018 10:59:40 +0200 From: Jan Kara Subject: Re: [PATCH V3 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Message-ID: <20180809085940.GC5069@quack2.suse.cz> References: <01aaca83694c3b0093fcb2f48af1dff0b147a4b2.1533811181.git.yi.z.zhang@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <01aaca83694c3b0093fcb2f48af1dff0b147a4b2.1533811181.git.yi.z.zhang@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Zhang Yi Cc: jack@suse.cz, yu.c.zhang@intel.com, kvm@vger.kernel.org, linux-nvdimm@lists.01.org, rkrcmar@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, hch@lst.de, yi.z.zhang@intel.com List-ID: On Thu 09-08-18 18:53:08, Zhang Yi wrote: > Currently, NVDIMM pages will be marked 'PageReserved'. However, unlike > other reserved PFNs, pages on NVDIMM shall still behave like normal ones > in many cases, i.e. when used as backend memory of KVM guest. This patch > introduces a new memory type, MEMORY_DEVICE_DEV_DAX. And set this flag > while dax driver hotplug the device memory. > > Signed-off-by: Zhang Yi > Signed-off-by: Zhang Yu Looks good to me now. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/dax/pmem.c | 1 + > include/linux/memremap.h | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/drivers/dax/pmem.c b/drivers/dax/pmem.c > index fd49b24..fb3f363 100644 > --- a/drivers/dax/pmem.c > +++ b/drivers/dax/pmem.c > @@ -111,6 +111,7 @@ static int dax_pmem_probe(struct device *dev) > return rc; > > dax_pmem->pgmap.ref = &dax_pmem->ref; > + dax_pmem->pgmap.type = MEMORY_DEVICE_DEV_DAX; > addr = devm_memremap_pages(dev, &dax_pmem->pgmap); > if (IS_ERR(addr)) > return PTR_ERR(addr); > diff --git a/include/linux/memremap.h b/include/linux/memremap.h > index f91f9e7..cd07ca8 100644 > --- a/include/linux/memremap.h > +++ b/include/linux/memremap.h > @@ -53,11 +53,19 @@ struct vmem_altmap { > * wakeup event whenever a page is unpinned and becomes idle. This > * wakeup is used to coordinate physical address space management (ex: > * fs truncate/hole punch) vs pinned pages (ex: device dma). > + * > + * MEMORY_DEVICE_DEV_DAX: > + * Device memory that support raw access to persistent memory. Without need > + * of an intervening filesystem, it could be directed mapped via an mmap > + * capable character device. Together with the type MEMORY_DEVICE_FS_DAX, > + * we could distinguish the persistent memory pages from normal ZONE_DEVICE > + * pages. > */ > enum memory_type { > MEMORY_DEVICE_PRIVATE = 1, > MEMORY_DEVICE_PUBLIC, > MEMORY_DEVICE_FS_DAX, > + MEMORY_DEVICE_DEV_DAX, > }; > > /* > -- > 2.7.4 > -- Jan Kara SUSE Labs, CR _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm