nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Zhang Yi <yi.z.zhang@linux.intel.com>
Cc: jack@suse.cz, yu.c.zhang@intel.com, kvm@vger.kernel.org,
	linux-nvdimm@lists.01.org, rkrcmar@redhat.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	pbonzini@redhat.com, hch@lst.de, yi.z.zhang@intel.com
Subject: Re: [PATCH V3 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio
Date: Thu, 9 Aug 2018 11:02:08 +0200	[thread overview]
Message-ID: <20180809090208.GD5069@quack2.suse.cz> (raw)
In-Reply-To: <cover.1533811181.git.yi.z.zhang@linux.intel.com>

On Thu 09-08-18 18:52:48, Zhang Yi wrote:
> For device specific memory space, when we move these area of pfn to
> memory zone, we will set the page reserved flag at that time, some of
> these reserved for device mmio, and some of these are not, such as
> NVDIMM pmem.
> 
> Now, we map these dev_dax or fs_dax pages to kvm for DIMM/NVDIMM
> backend, since these pages are reserved. the check of
> kvm_is_reserved_pfn() misconceives those pages as MMIO. Therefor, we
> introduce 2 page map types, MEMORY_DEVICE_FS_DAX/MEMORY_DEVICE_DEV_DAX,
> to indentify these pages are from NVDIMM pmem. and let kvm treat these
> as normal pages.
> 
> Without this patch, Many operations will be missed due to this
> mistreatment to pmem pages. For example, a page may not have chance to
> be unpinned for KVM guest(in kvm_release_pfn_clean); not able to be
> marked as dirty/accessed(in kvm_set_pfn_dirty/accessed) etc.
> 
> V1:
> https://lkml.org/lkml/2018/7/4/91
> 
> V2:
> https://lkml.org/lkml/2018/7/10/135
> 
> V3:
> [PATCH V3 1/4] Needs Comments.
> [PATCH V3 2/4] Update the description of MEMORY_DEVICE_DEV_DAX: Jan
> [PATCH V3 3/4] Acked-by: Jan in V2

Hum, but it is not the the patch...

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2018-08-09  9:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 10:52 [PATCH V3 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang Yi
2018-08-09  9:02 ` Jan Kara [this message]
2018-08-13 17:33   ` Zhang,Yi
2018-08-09 10:52 ` [PATCH V3 1/4] kvm: remove redundant reserved page check Zhang Yi
2018-08-09  9:13   ` Pankaj Gupta
2018-08-10 11:23   ` David Hildenbrand
2018-08-09 10:53 ` [PATCH V3 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-08-09  8:59   ` Jan Kara
2018-08-09 10:53 ` [PATCH V3 3/4] mm: add a function to differentiate the pages is from DAX device memory Zhang Yi
2018-08-09  9:23   ` Pankaj Gupta
2018-08-13 17:41     ` Zhang,Yi
2018-08-13 14:29       ` Jerome Glisse
2018-08-09 10:53 ` [PATCH V3 4/4] kvm: add a check if pfn is from NVDIMM pmem Zhang Yi
2018-08-09  8:32   ` Pankaj Gupta
2018-08-13 17:32     ` Zhang,Yi
2018-08-10 13:27 ` [PATCH V3 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio David Hildenbrand
2018-08-13 17:25   ` Zhang,Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809090208.GD5069@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=hch@lst.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=yi.z.zhang@intel.com \
    --cc=yi.z.zhang@linux.intel.com \
    --cc=yu.c.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).