nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Vishal Verma <vishal.l.verma@intel.com>
To: linux-nvdimm@lists.01.org
Cc: Steve Scargal <steve.scargall@intel.com>
Subject: [ndctl PATCH 0/2] xaction-namespace counting reworks
Date: Wed, 22 Aug 2018 16:22:47 -0600	[thread overview]
Message-ID: <20180822222249.30838-1-vishal.l.verma@intel.com> (raw)

There have been several reports of the counts printed for namespace
actions such as enable, disable, and especially destroy being incorrect
and confusing. These patches are an attempt to clean up and bring
greater consistency to these operations.

Patch 1 lays some groundwork for testing whether a namespace (under
destroy-namespace) that is supposed to have metadata due to its
personality (btt, pfn, dev-dax) has already had its info-blocks zeroed.
If that is the case, then allow for skipping the zeroing, and
communicate the fact. This is really only applicable for legacy
namespaces as in the labeled case, the label would have been
inconsistent if the metadata had been previously wiped.

Patch 2 builds on the above by creating a harder separation between the
result of an action vs. the number of objects (namespaces) the action
actually processed. Making the result independent of the number
processed allows us to make a cleaner decision on what exactly was done,
and print errors and/or counts accordingly.

Vishal Verma (2):
  ndctl, destroy-namespace: check for an already-zeroed info block
  ndctl, namespace: rework namespace action accounting

 ndctl/namespace.c | 197 ++++++++++++++++++++++++++++++++----------------------
 1 file changed, 116 insertions(+), 81 deletions(-)

-- 
2.14.4

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

             reply	other threads:[~2018-08-22 22:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22 22:22 Vishal Verma [this message]
2018-08-22 22:22 ` [ndctl PATCH 1/2] ndctl, destroy-namespace: check for an already-zeroed info block Vishal Verma
2018-08-22 22:22 ` [ndctl PATCH 2/2] ndctl, namespace: rework namespace action accounting Vishal Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822222249.30838-1-vishal.l.verma@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=steve.scargall@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).