From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5D14821128700 for ; Tue, 11 Sep 2018 08:27:08 -0700 (PDT) Date: Tue, 11 Sep 2018 17:27:06 +0200 From: Jan Kara Subject: Re: open sets ext4_da_aops for DAX existing files Message-ID: <20180911152706.GG6104@quack2.suse.cz> References: <76e07643e9c36e4273588bd3e7f29d1393de4c3d.camel@hpe.com> <20180910142902.GA30197@quack2.suse.cz> <0768c59f2d5391ff7678370fbc72cb664fca25fd.camel@hpe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Elliott, Robert (Persistent Memory)" Cc: "linux-fsdevel@vger.kernel.org" , "jack@suse.cz" , "linux-nvdimm@lists.01.org" List-ID: On Mon 10-09-18 17:58:10, Elliott, Robert (Persistent Memory) wrote: > > > > -----Original Message----- > > From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of Kani, Toshi > > Sent: Monday, September 10, 2018 9:52 AM > > To: jack@suse.cz > > Cc: linux-fsdevel@vger.kernel.org; linux-nvdimm@lists.01.org > > Subject: Re: open sets ext4_da_aops for DAX existing files > ... > > > Good catch. Will you send a fix? I.e., call ext4_set_inode_flags() earlier > > > in the ext4_iget()? Did this bug have any user visible manifestations? > > > > Yes, sync did not flush processor cache. > > > > > Please also add: > > > > > > Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086 > > > > > > so that stable automation picks this up. Thanks! > > > > > > > Will do. > > > > Also check if the same problem exists with ext2. The problem also exists in ext2 so that needs fixing as well. Honza -- Jan Kara SUSE Labs, CR _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm