nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: GuangZhe Fu <fugz2012@zoho.com>
To: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
Cc: fugz2012@zoho.com, GuangZhe Fu <fugz1@lenovo.com>
Subject: [PATCH] libnvdimm, namespace: Drop the repeat assignment for variable dev->parent
Date: Mon,  1 Oct 2018 23:35:00 -0400	[thread overview]
Message-ID: <20181002033500.3383-1-fugz2012@zoho.com> (raw)

From: GuangZhe Fu <fugz1@lenovo.com>

The variable dev-parent is assigned twice with the same &nd_region->dev. I think we could drop the second one.

Signed-off-by: GuangZhe Fu <fugz1@lenovo.com>
 drivers/nvdimm/namespace_devs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
index cb322f2..db0abf1 100644
--- a/drivers/nvdimm/namespace_devs.c
+++ b/drivers/nvdimm/namespace_devs.c
@@ -2099,7 +2099,6 @@ static struct device *nd_namespace_pmem_create(struct nd_region *nd_region)
 		return NULL;
 	dev_set_name(dev, "namespace%d.%d", nd_region->id, nspm->id);
-	dev->parent = &nd_region->dev;
 	dev->groups = nd_namespace_attribute_groups;
 	nd_namespace_pmem_set_resource(nd_region, nspm, 0);

Linux-nvdimm mailing list

             reply	other threads:[~2018-10-02  3:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02  3:35 GuangZhe Fu [this message]
2018-10-02  3:40 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002033500.3383-1-fugz2012@zoho.com \
    --to=fugz2012@zoho.com \
    --cc=fugz1@lenovo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --subject='Re: [PATCH] libnvdimm, namespace: Drop the repeat assignment for variable dev->parent' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).