From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, qemu-devel@nongnu.org,
linux-nvdimm@ml01.01.org, jack@suse.cz, stefanha@redhat.com,
dan.j.williams@intel.com, riel@surriel.com, nilal@redhat.com,
kwolf@redhat.com, pbonzini@redhat.com, zwisler@kernel.org,
vishal.l.verma@intel.com, dave.jiang@intel.com, david@redhat.com,
xiaoguangrong.eric@gmail.com, hch@infradead.org, mst@redhat.com,
lcapitulino@redhat.com, imammedo@redhat.com, eblake@redhat.com,
pagupta@redhat.com
Subject: Re: [PATCH v2 1/2] libnvdimm: nd_region flush callback support
Date: Sat, 13 Oct 2018 16:31:22 +0800 [thread overview]
Message-ID: <201810131656.iac7lk1I%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181013050021.11962-2-pagupta@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 4472 bytes --]
Hi Pankaj,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linux-nvdimm/libnvdimm-for-next]
[also build test WARNING on v4.19-rc7 next-20181012]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pankaj-Gupta/libnvdimm-nd_region-flush-callback-support/20181013-152624
base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next
config: x86_64-randconfig-x017-201840 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from drivers/nvdimm/bus.c:14:0:
>> include/linux/libnvdimm.h:206:54: warning: 'struct bio' declared inside parameter list will not be visible outside of this definition or declaration
int nvdimm_flush(struct nd_region *nd_region, struct bio *bio, bool async);
^~~
vim +206 include/linux/libnvdimm.h
159
160 void badrange_init(struct badrange *badrange);
161 int badrange_add(struct badrange *badrange, u64 addr, u64 length);
162 void badrange_forget(struct badrange *badrange, phys_addr_t start,
163 unsigned int len);
164 int nvdimm_bus_add_badrange(struct nvdimm_bus *nvdimm_bus, u64 addr,
165 u64 length);
166 struct nvdimm_bus *nvdimm_bus_register(struct device *parent,
167 struct nvdimm_bus_descriptor *nfit_desc);
168 void nvdimm_bus_unregister(struct nvdimm_bus *nvdimm_bus);
169 struct nvdimm_bus *to_nvdimm_bus(struct device *dev);
170 struct nvdimm *to_nvdimm(struct device *dev);
171 struct nd_region *to_nd_region(struct device *dev);
172 struct device *nd_region_dev(struct nd_region *nd_region);
173 struct nd_blk_region *to_nd_blk_region(struct device *dev);
174 struct nvdimm_bus_descriptor *to_nd_desc(struct nvdimm_bus *nvdimm_bus);
175 struct device *to_nvdimm_bus_dev(struct nvdimm_bus *nvdimm_bus);
176 const char *nvdimm_name(struct nvdimm *nvdimm);
177 struct kobject *nvdimm_kobj(struct nvdimm *nvdimm);
178 unsigned long nvdimm_cmd_mask(struct nvdimm *nvdimm);
179 void *nvdimm_provider_data(struct nvdimm *nvdimm);
180 struct nvdimm *nvdimm_create(struct nvdimm_bus *nvdimm_bus, void *provider_data,
181 const struct attribute_group **groups, unsigned long flags,
182 unsigned long cmd_mask, int num_flush,
183 struct resource *flush_wpq);
184 const struct nd_cmd_desc *nd_cmd_dimm_desc(int cmd);
185 const struct nd_cmd_desc *nd_cmd_bus_desc(int cmd);
186 u32 nd_cmd_in_size(struct nvdimm *nvdimm, int cmd,
187 const struct nd_cmd_desc *desc, int idx, void *buf);
188 u32 nd_cmd_out_size(struct nvdimm *nvdimm, int cmd,
189 const struct nd_cmd_desc *desc, int idx, const u32 *in_field,
190 const u32 *out_field, unsigned long remainder);
191 int nvdimm_bus_check_dimm_count(struct nvdimm_bus *nvdimm_bus, int dimm_count);
192 struct nd_region *nvdimm_pmem_region_create(struct nvdimm_bus *nvdimm_bus,
193 struct nd_region_desc *ndr_desc);
194 struct nd_region *nvdimm_blk_region_create(struct nvdimm_bus *nvdimm_bus,
195 struct nd_region_desc *ndr_desc);
196 struct nd_region *nvdimm_volatile_region_create(struct nvdimm_bus *nvdimm_bus,
197 struct nd_region_desc *ndr_desc);
198 void *nd_region_provider_data(struct nd_region *nd_region);
199 void *nd_blk_region_provider_data(struct nd_blk_region *ndbr);
200 void nd_blk_region_set_provider_data(struct nd_blk_region *ndbr, void *data);
201 struct nvdimm *nd_blk_region_to_dimm(struct nd_blk_region *ndbr);
202 unsigned long nd_blk_memremap_flags(struct nd_blk_region *ndbr);
203 unsigned int nd_region_acquire_lane(struct nd_region *nd_region);
204 void nd_region_release_lane(struct nd_region *nd_region, unsigned int lane);
205 u64 nd_fletcher64(void *addr, size_t len, bool le);
> 206 int nvdimm_flush(struct nd_region *nd_region, struct bio *bio, bool async);
207 int generic_nvdimm_flush(struct nd_region *nd_region);
208 int nvdimm_has_flush(struct nd_region *nd_region);
209 int nvdimm_has_cache(struct nd_region *nd_region);
210
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33326 bytes --]
next prev parent reply other threads:[~2018-10-13 8:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 5:00 [PATCH v2 0/2] kvm "fake DAX" device Pankaj Gupta
[not found] ` <20181013050021.11962-1-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-10-13 5:00 ` [PATCH v2 1/2] libnvdimm: nd_region flush callback support Pankaj Gupta
2018-10-13 8:31 ` kbuild test robot [this message]
[not found] ` <20181013050021.11962-2-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-10-13 9:38 ` kbuild test robot
2018-10-13 16:06 ` [PATCH v2 0/2] kvm "fake DAX" device Dan Williams
2018-10-13 16:29 ` [Qemu-devel] " Pankaj Gupta
2018-10-13 5:00 ` [PATCH v2 2/2] virtio-pmem: Add virtio pmem driver Pankaj Gupta
[not found] ` <20181013050021.11962-3-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-10-13 16:10 ` Dan Williams
[not found] ` <CAPcyv4hroaVWA-HgjWCnr7QTd_y7U8sCvS+Up733ttnD6_cKzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-10-17 19:11 ` [Qemu-devel] " Pankaj Gupta
2018-10-17 19:36 ` Dan Williams
2018-10-18 1:44 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201810131656.iac7lk1I%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=hch@infradead.org \
--cc=imammedo@redhat.com \
--cc=jack@suse.cz \
--cc=kbuild-all@01.org \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@surriel.com \
--cc=stefanha@redhat.com \
--cc=vishal.l.verma@intel.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).