From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C0F8621163248 for ; Mon, 3 Dec 2018 15:44:01 -0800 (PST) Received: by mail-pg1-f195.google.com with SMTP id z11so6468247pgu.0 for ; Mon, 03 Dec 2018 15:44:01 -0800 (PST) Date: Mon, 3 Dec 2018 15:43:55 -0800 From: Luis Chamberlain Subject: Re: [RFC v3 07/19] kunit: test: add initial tests Message-ID: <20181203234355.GQ28501@garbanzo.do-not-panic.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-8-brendanhiggins@google.com> <20181130034001.GM18410@garbanzo.do-not-panic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: brakmo@fb.com, dri-devel@lists.freedesktop.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , Frank Rowand , linux-nvdimm@lists.01.org, richard@nod.at, Knut Omang , kieran.bingham@ideasonboard.com, Joel Stanley , jdike@addtoit.com, Tim.Bird@sony.com, Kees Cook , linux-um@lists.infradead.org, rostedt@goodmis.org, Julia Lawall , kunit-dev@googlegroups.com, Greg KH , Linux Kernel Mailing List , Daniel Vetter , mpe@ellerman.id.au, joe@perches.com, khilman@baylibre.com List-ID: On Mon, Dec 03, 2018 at 03:26:26PM -0800, Brendan Higgins wrote: > On Thu, Nov 29, 2018 at 7:40 PM Luis Chamberlain wrote: > > > > On Wed, Nov 28, 2018 at 11:36:24AM -0800, Brendan Higgins wrote: > > > Add a test for string stream along with a simpler example. > > > > > > Signed-off-by: Brendan Higgins > > > --- > > > kunit/Kconfig | 12 ++++++ > > > kunit/Makefile | 4 ++ > > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > > > BTW if you need another more concrete but very simple example I think it > > may be possible to port tools/testing/selftests/sysctl/sysctl.sh + > > lib/test_sysctl.c into a kunit test. Correct me if I'm wrong. > > I think that is pretty doable. I don't know that I want to shoot for > that on the next revision. But I can definitely do it in a later > revision, or a later patchset, unless you would strongly prefer it > now, that is. No rush on my end, just figured I'd mention a simple candidate in case you needed another one to evaluate. Luis _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm