From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=d9u0=CZ=lists.01.org=linux-nvdimm-bounces@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,
	SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 86631C43461
	for <linux-nvdimm@archiver.kernel.org>; Wed, 16 Sep 2020 12:52:22 +0000 (UTC)
Received: from ml01.01.org (ml01.01.org [198.145.21.10])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id E3A0622272
	for <linux-nvdimm@archiver.kernel.org>; Wed, 16 Sep 2020 12:52:21 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3A0622272
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org
Received: from ml01.vlan13.01.org (localhost [IPv6:::1])
	by ml01.01.org (Postfix) with ESMTP id 9931D144CFAB0;
	Wed, 16 Sep 2020 05:52:21 -0700 (PDT)
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=115.124.30.45; helo=out30-45.freemail.mail.aliyun.com; envelope-from=richard.weiyang@linux.alibaba.com; receiver=<UNKNOWN> 
Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ml01.01.org (Postfix) with ESMTPS id BDA48144137AF
	for <linux-nvdimm@lists.01.org>; Wed, 16 Sep 2020 05:52:18 -0700 (PDT)
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R931e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=richard.weiyang@linux.alibaba.com;NM=1;PH=DS;RN=17;SR=0;TI=SMTPD_---0U97x1KA_1600260734;
Received: from localhost(mailfrom:richard.weiyang@linux.alibaba.com fp:SMTPD_---0U97x1KA_1600260734)
          by smtp.aliyun-inc.com(127.0.0.1);
          Wed, 16 Sep 2020 20:52:14 +0800
Date: Wed, 16 Sep 2020 20:52:14 +0800
From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v4 6/8] virtio-mem: try to merge system ram resources
Message-ID: <20200916125214.GB48039@L-31X9LVDL-1304.local>
References: <20200911103459.10306-1-david@redhat.com>
 <20200911103459.10306-7-david@redhat.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20200911103459.10306-7-david@redhat.com>
Message-ID-Hash: UX5C7DKJZRCWZJXCHKGTTKAZHZUV26SX
X-Message-ID-Hash: UX5C7DKJZRCWZJXCHKGTTKAZHZUV26SX
X-MailFrom: richard.weiyang@linux.alibaba.com
X-Mailman-Rule-Hits: nonmember-moderation
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation
CC: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-s390@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Pankaj Gupta <pankaj.gupta.linux@gmail.com>, Michal Hocko <mhocko@suse.com>, "Michael S . Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Baoquan He <bhe@redhat.com>
X-Mailman-Version: 3.1.1
Precedence: list
Reply-To: Wei Yang <richard.weiyang@linux.alibaba.com>
List-Id: "Linux-nvdimm developer list." <linux-nvdimm.lists.01.org>
Archived-At: <https://lists.01.org/hyperkitty/list/linux-nvdimm@lists.01.org/message/UX5C7DKJZRCWZJXCHKGTTKAZHZUV26SX/>
List-Archive: <https://lists.01.org/hyperkitty/list/linux-nvdimm@lists.01.org/>
List-Help: <mailto:linux-nvdimm-request@lists.01.org?subject=help>
List-Post: <mailto:linux-nvdimm@lists.01.org>
List-Subscribe: <mailto:linux-nvdimm-join@lists.01.org>
List-Unsubscribe: <mailto:linux-nvdimm-leave@lists.01.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Fri, Sep 11, 2020 at 12:34:57PM +0200, David Hildenbrand wrote:
>virtio-mem adds memory in memory block granularity, to be able to
>remove it in the same granularity again later, and to grow slowly on
>demand. This, however, results in quite a lot of resources when
>adding a lot of memory. Resources are effectively stored in a list-based
>tree. Having a lot of resources not only wastes memory, it also makes
>traversing that tree more expensive, and makes /proc/iomem explode in
>size (e.g., requiring kexec-tools to manually merge resources later
>when e.g., trying to create a kdump header).
>
>Before this patch, we get (/proc/iomem) when hotplugging 2G via virtio-mem
>on x86-64:
>        [...]
>        100000000-13fffffff : System RAM
>        140000000-33fffffff : virtio0
>          140000000-147ffffff : System RAM (virtio_mem)
>          148000000-14fffffff : System RAM (virtio_mem)
>          150000000-157ffffff : System RAM (virtio_mem)
>          158000000-15fffffff : System RAM (virtio_mem)
>          160000000-167ffffff : System RAM (virtio_mem)
>          168000000-16fffffff : System RAM (virtio_mem)
>          170000000-177ffffff : System RAM (virtio_mem)
>          178000000-17fffffff : System RAM (virtio_mem)
>          180000000-187ffffff : System RAM (virtio_mem)
>          188000000-18fffffff : System RAM (virtio_mem)
>          190000000-197ffffff : System RAM (virtio_mem)
>          198000000-19fffffff : System RAM (virtio_mem)
>          1a0000000-1a7ffffff : System RAM (virtio_mem)
>          1a8000000-1afffffff : System RAM (virtio_mem)
>          1b0000000-1b7ffffff : System RAM (virtio_mem)
>          1b8000000-1bfffffff : System RAM (virtio_mem)
>        3280000000-32ffffffff : PCI Bus 0000:00
>
>With this patch, we get (/proc/iomem):
>        [...]
>        fffc0000-ffffffff : Reserved
>        100000000-13fffffff : System RAM
>        140000000-33fffffff : virtio0
>          140000000-1bfffffff : System RAM (virtio_mem)
>        3280000000-32ffffffff : PCI Bus 0000:00
>
>Of course, with more hotplugged memory, it gets worse. When unplugging
>memory blocks again, try_remove_memory() (via
>offline_and_remove_memory()) will properly split the resource up again.
>
>Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
>Cc: Andrew Morton <akpm@linux-foundation.org>
>Cc: Michal Hocko <mhocko@suse.com>
>Cc: Dan Williams <dan.j.williams@intel.com>
>Cc: Michael S. Tsirkin <mst@redhat.com>
>Cc: Jason Wang <jasowang@redhat.com>
>Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
>Cc: Baoquan He <bhe@redhat.com>
>Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Wei Yang <richard.weiyang@linux.alibaba.com>

>---
> drivers/virtio/virtio_mem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
>index ed99e43354010..ba4de598f6636 100644
>--- a/drivers/virtio/virtio_mem.c
>+++ b/drivers/virtio/virtio_mem.c
>@@ -424,7 +424,8 @@ static int virtio_mem_mb_add(struct virtio_mem *vm, unsigned long mb_id)
> 
> 	dev_dbg(&vm->vdev->dev, "adding memory block: %lu\n", mb_id);
> 	return add_memory_driver_managed(nid, addr, memory_block_size_bytes(),
>-					 vm->resource_name, MHP_NONE);
>+					 vm->resource_name,
>+					 MEMHP_MERGE_RESOURCE);
> }
> 
> /*
>-- 
>2.26.2

-- 
Wei Yang
Help you, Help me
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org