From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CA5BC433E6 for ; Fri, 19 Feb 2021 02:04:00 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0E1B64ED2 for ; Fri, 19 Feb 2021 02:03:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0E1B64ED2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E1365100EAB5E; Thu, 18 Feb 2021 18:03:56 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=vishal.l.verma@intel.com; receiver= Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 18014100EBBD7 for ; Thu, 18 Feb 2021 18:03:52 -0800 (PST) IronPort-SDR: RkeL9bPEnyipwwIUbjbW3Bj46Y/9KIQ5UKtiZ6Kkl0Rd5NAJPRWCg44iThJFw9kOaSO69bazAq 0KQDh6cxnZQg== X-IronPort-AV: E=McAfee;i="6000,8403,9899"; a="181151493" X-IronPort-AV: E=Sophos;i="5.81,187,1610438400"; d="scan'208";a="181151493" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2021 18:03:51 -0800 IronPort-SDR: jdaKB+YDyDJ+IZ7gyMBIa3zfwDJz3BFkmpPIsLXcMA6PPjetnain+6Uggd3J6l4OBA/zhpQ1TM KDRBsk+TeEdg== X-IronPort-AV: E=Sophos;i="5.81,187,1610438400"; d="scan'208";a="513509636" Received: from jnavar1-mobl4.amr.corp.intel.com (HELO omniknight.intel.com) ([10.213.167.18]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2021 18:03:51 -0800 From: Vishal Verma To: Subject: [ndctl PATCH v2 04/13] libcxl: add support for the 'Identify Device' command Date: Thu, 18 Feb 2021 19:03:22 -0700 Message-Id: <20210219020331.725687-5-vishal.l.verma@intel.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210219020331.725687-1-vishal.l.verma@intel.com> References: <20210219020331.725687-1-vishal.l.verma@intel.com> MIME-Version: 1.0 Message-ID-Hash: CZIWYHZEQ5BQYSPI46LEZ2PMEJLEGIR5 X-Message-ID-Hash: CZIWYHZEQ5BQYSPI46LEZ2PMEJLEGIR5 X-MailFrom: vishal.l.verma@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-nvdimm@lists.01.org, Ben Widawsky X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Add APIs to allocate and send an 'Identify Device' command, and accessors to retrieve some of the fields from the resulting data. Only add a handful accessor functions; more can be added as the need arises. The fields added are fw_revision, partition_align, and lsa_size. Cc: Ben Widawsky Cc: Dan Williams Signed-off-by: Vishal Verma --- cxl/lib/private.h | 19 ++++++++++++++++++ cxl/lib/libcxl.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++ cxl/libcxl.h | 4 ++++ cxl/lib/libcxl.sym | 4 ++++ 4 files changed, 76 insertions(+) diff --git a/cxl/lib/private.h b/cxl/lib/private.h index 87ca17e..3273f21 100644 --- a/cxl/lib/private.h +++ b/cxl/lib/private.h @@ -54,6 +54,25 @@ struct cxl_cmd { int status; }; +#define CXL_CMD_IDENTIFY_FW_REV_LENGTH 0x10 + +struct cxl_cmd_identify { + char fw_revision[CXL_CMD_IDENTIFY_FW_REV_LENGTH]; + le64 total_capacity; + le64 volatile_capacity; + le64 persistent_capacity; + le64 partition_align; + le16 info_event_log_size; + le16 warning_event_log_size; + le16 failure_event_log_size; + le16 fatal_event_log_size; + le32 lsa_size; + u8 poison_list_max_mer[3]; + le16 inject_poison_limit; + u8 poison_caps; + u8 qos_telemetry_caps; +} __attribute__((packed)); + static inline int check_kmod(struct kmod_ctx *kmod_ctx) { return kmod_ctx ? 0 : -ENXIO; diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c index f1155a1..4751cba 100644 --- a/cxl/lib/libcxl.c +++ b/cxl/lib/libcxl.c @@ -13,7 +13,10 @@ #include #include #include +#include +#include #include +#include #include #include @@ -675,6 +678,52 @@ CXL_EXPORT const char *cxl_cmd_get_devname(struct cxl_cmd *cmd) return cxl_memdev_get_devname(cmd->memdev); } +CXL_EXPORT struct cxl_cmd *cxl_cmd_new_identify(struct cxl_memdev *memdev) +{ + return cxl_cmd_new_generic(memdev, CXL_MEM_COMMAND_ID_IDENTIFY); +} + +CXL_EXPORT int cxl_cmd_identify_get_fw_rev(struct cxl_cmd *cmd, char *fw_rev, + int fw_len) +{ + struct cxl_cmd_identify *id = (void *)cmd->send_cmd->out.payload; + + if (cmd->send_cmd->id != CXL_MEM_COMMAND_ID_IDENTIFY) + return -EINVAL; + if (cmd->status < 0) + return cmd->status; + + if (fw_len > 0) + memcpy(fw_rev, id->fw_revision, + min(fw_len, CXL_CMD_IDENTIFY_FW_REV_LENGTH)); + return 0; +} + +CXL_EXPORT unsigned long long cxl_cmd_identify_get_partition_align( + struct cxl_cmd *cmd) +{ + struct cxl_cmd_identify *id = (void *)cmd->send_cmd->out.payload; + + if (cmd->send_cmd->id != CXL_MEM_COMMAND_ID_IDENTIFY) + return -EINVAL; + if (cmd->status < 0) + return cmd->status; + + return le64_to_cpu(id->partition_align); +} + +CXL_EXPORT unsigned int cxl_cmd_identify_get_lsa_size(struct cxl_cmd *cmd) +{ + struct cxl_cmd_identify *id = (void *)cmd->send_cmd->out.payload; + + if (cmd->send_cmd->id != CXL_MEM_COMMAND_ID_IDENTIFY) + return -EINVAL; + if (cmd->status < 0) + return cmd->status; + + return le32_to_cpu(id->lsa_size); +} + CXL_EXPORT struct cxl_cmd *cxl_cmd_new_raw(struct cxl_memdev *memdev, int opcode) { diff --git a/cxl/libcxl.h b/cxl/libcxl.h index 6e87b80..9ed8c83 100644 --- a/cxl/libcxl.h +++ b/cxl/libcxl.h @@ -58,6 +58,10 @@ void cxl_cmd_unref(struct cxl_cmd *cmd); int cxl_cmd_submit(struct cxl_cmd *cmd); int cxl_cmd_get_mbox_status(struct cxl_cmd *cmd); int cxl_cmd_get_out_size(struct cxl_cmd *cmd); +struct cxl_cmd *cxl_cmd_new_identify(struct cxl_memdev *memdev); +int cxl_cmd_identify_get_fw_rev(struct cxl_cmd *cmd, char *fw_rev, int fw_len); +unsigned long long cxl_cmd_identify_get_partition_align(struct cxl_cmd *cmd); +unsigned int cxl_cmd_identify_get_lsa_size(struct cxl_cmd *cmd); #ifdef __cplusplus } /* extern "C" */ diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym index 493429c..d6aa0b2 100644 --- a/cxl/lib/libcxl.sym +++ b/cxl/lib/libcxl.sym @@ -39,4 +39,8 @@ global: cxl_cmd_submit; cxl_cmd_get_mbox_status; cxl_cmd_get_out_size; + cxl_cmd_new_identify; + cxl_cmd_identify_get_fw_rev; + cxl_cmd_identify_get_partition_align; + cxl_cmd_identify_get_lsa_size; } LIBCXL_2; -- 2.29.2 _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org