From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0C0D2F80 for ; Thu, 2 Sep 2021 07:43:45 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id CF11268B05; Thu, 2 Sep 2021 09:43:43 +0200 (CEST) Date: Thu, 2 Sep 2021 09:43:42 +0200 From: Christoph Hellwig To: Shiyang Ruan Cc: djwong@kernel.org, hch@lst.de, linux-xfs@vger.kernel.org, dan.j.williams@intel.com, david@fromorbit.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, rgoldwyn@suse.de, viro@zeniv.linux.org.uk, willy@infradead.org Subject: Re: [PATCH v8 7/7] xfs: Add dax dedupe support Message-ID: <20210902074342.GF13867@lst.de> References: <20210829122517.1648171-1-ruansy.fnst@fujitsu.com> <20210829122517.1648171-8-ruansy.fnst@fujitsu.com> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210829122517.1648171-8-ruansy.fnst@fujitsu.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Sun, Aug 29, 2021 at 08:25:17PM +0800, Shiyang Ruan wrote: > Introduce xfs_mmaplock_two_inodes_and_break_dax_layout() for dax files > who are going to be deduped. After that, call compare range function > only when files are both DAX or not. > > Signed-off-by: Shiyang Ruan > Reviewed-by: Darrick J. Wong Looks good, Reviewed-by: Christoph Hellwig