* [regression] fs dax xfstests panic
@ 2021-09-27 6:17 Murphy Zhou
2021-09-27 11:51 ` Christoph Hellwig
0 siblings, 1 reply; 8+ messages in thread
From: Murphy Zhou @ 2021-09-27 6:17 UTC (permalink / raw)
To: nvdimm, hch; +Cc: linux-fsdevel
Hi folks,
Since this commit:
commit edb0872f44ec9976ea6d052cb4b93cd2d23ac2ba
Author: Christoph Hellwig <hch@lst.de>
Date: Mon Aug 9 16:17:43 2021 +0200
block: move the bdi from the request_queue to the gendisk
Looping xfstests generic/108 or xfs/279 on mountpoints with fsdax
enabled can lead to panic like this:
[ 373.882656] BUG: kernel NULL pointer dereference, address: 0000000000000300
[ 373.893342] #PF: supervisor read access in kernel mode
[ 373.899082] #PF: error_code(0x0000) - not-present page
[ 373.904820] PGD 0 P4D 0
[ 373.907647] Oops: 0000 [#1] SMP PTI
[ 373.911542] CPU: 5 PID: 0 Comm: swapper/5 Kdump: loaded Tainted: G I 5.14.0-rc4+ #1
[ 373.921544] Hardware name: Lenovo ThinkSystem SR630 -[7X02CTO1WW]-/-[7X02CTO1WW]-, BIOS -[IVE116S-1.20]- 02/08/2018
[ 373.933193] RIP: 0010:wb_timer_fn+0x3a/0x3c0
[ 373.937966] Code: 60 4c 8b 67 50 8b 9d 98 00 00 00 8b 95 b8 00 00 00 8b 85 d8 00 00 00 4c 8b 6d 28 01 d3 01 c3 48 8b 45 60 48 8b 80 90 00 00 00 <48> 8b 80 00 03 00 00 4c 8b b0 98 00 00 00 4d 85 ed 0f 84 ca 00 00
[ 373.958915] RSP: 0018:ffffaa0f465e4eb0 EFLAGS: 00010246
[ 373.964748] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000020
[ 373.972712] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff937c41649500
[ 373.980676] RBP: ffff937bf0f38400 R08: 0000000000000020 R09: 0000000000000000
[ 373.988641] R10: 0000000000000020 R11: 000000000000003d R12: ffff937d2bbf0d20
[ 373.996606] R13: 0000000000000000 R14: 0000000000000000 R15: ffff937f2f55c0c0
[ 374.004570] FS: 0000000000000000(0000) GS:ffff937f2f540000(0000) knlGS:0000000000000000
[ 374.013602] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 374.020015] CR2: 0000000000000300 CR3: 0000000c14c10003 CR4: 00000000007706e0
[ 374.027981] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 374.035944] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 374.043907] PKRU: 55555554
[ 374.046927] Call Trace:
[ 374.049657] <IRQ>
[ 374.051902] ? blk_stat_free_callback_rcu+0x30/0x30
[ 374.057350] call_timer_fn+0x26/0xf0
[ 374.061344] __run_timers.part.0+0x1c0/0x220
[ 374.066112] ? __hrtimer_run_queues+0x136/0x270
[ 374.071169] ? recalibrate_cpu_khz+0x10/0x10
[ 374.075940] ? ktime_get+0x38/0x90
[ 374.079737] run_timer_softirq+0x26/0x50
[ 374.084106] __do_softirq+0xca/0x276
[ 374.088102] __irq_exit_rcu+0xc1/0xe0
[ 374.092195] sysvec_apic_timer_interrupt+0x72/0x90
[ 374.097545] </IRQ>
[ 374.099885] asm_sysvec_apic_timer_interrupt+0x12/0x20
[ 374.105613] RIP: 0010:acpi_idle_do_entry+0x4c/0x50
It can be reliably reproduced on xfs or ext4. It was tested on pmem ramdisks.
Thanks,
Murphy
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [regression] fs dax xfstests panic
2021-09-27 6:17 [regression] fs dax xfstests panic Murphy Zhou
@ 2021-09-27 11:51 ` Christoph Hellwig
2021-09-27 23:02 ` Darrick J. Wong
0 siblings, 1 reply; 8+ messages in thread
From: Christoph Hellwig @ 2021-09-27 11:51 UTC (permalink / raw)
To: Murphy Zhou; +Cc: nvdimm, hch, linux-fsdevel
On Mon, Sep 27, 2021 at 02:17:47PM +0800, Murphy Zhou wrote:
> Hi folks,
>
> Since this commit:
>
> commit edb0872f44ec9976ea6d052cb4b93cd2d23ac2ba
> Author: Christoph Hellwig <hch@lst.de>
> Date: Mon Aug 9 16:17:43 2021 +0200
>
> block: move the bdi from the request_queue to the gendisk
>
>
> Looping xfstests generic/108 or xfs/279 on mountpoints with fsdax
> enabled can lead to panic like this:
Does this still happen with this series:
https://lore.kernel.org/linux-block/20210922172222.2453343-1-hch@lst.de/T/#m8dc646a4dfc40f443227da6bb1c77d9daec524db
?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [regression] fs dax xfstests panic
2021-09-27 11:51 ` Christoph Hellwig
@ 2021-09-27 23:02 ` Darrick J. Wong
2021-09-27 23:14 ` Dan Williams
2021-09-28 4:34 ` Christoph Hellwig
0 siblings, 2 replies; 8+ messages in thread
From: Darrick J. Wong @ 2021-09-27 23:02 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Murphy Zhou, nvdimm, linux-fsdevel
On Mon, Sep 27, 2021 at 01:51:16PM +0200, Christoph Hellwig wrote:
> On Mon, Sep 27, 2021 at 02:17:47PM +0800, Murphy Zhou wrote:
> > Hi folks,
> >
> > Since this commit:
> >
> > commit edb0872f44ec9976ea6d052cb4b93cd2d23ac2ba
> > Author: Christoph Hellwig <hch@lst.de>
> > Date: Mon Aug 9 16:17:43 2021 +0200
> >
> > block: move the bdi from the request_queue to the gendisk
> >
> >
> > Looping xfstests generic/108 or xfs/279 on mountpoints with fsdax
> > enabled can lead to panic like this:
>
> Does this still happen with this series:
>
> https://lore.kernel.org/linux-block/20210922172222.2453343-1-hch@lst.de/T/#m8dc646a4dfc40f443227da6bb1c77d9daec524db
>
> ?
My test machinse all hit this when writeback throttling is enabled, so
Tested-by: Darrick J. Wong <djwong@kernel.org>
--D
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [regression] fs dax xfstests panic
2021-09-27 23:02 ` Darrick J. Wong
@ 2021-09-27 23:14 ` Dan Williams
2021-09-28 4:34 ` Christoph Hellwig
1 sibling, 0 replies; 8+ messages in thread
From: Dan Williams @ 2021-09-27 23:14 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Christoph Hellwig, Murphy Zhou, Linux NVDIMM, linux-fsdevel
On Mon, Sep 27, 2021 at 4:03 PM Darrick J. Wong <djwong@kernel.org> wrote:
>
> On Mon, Sep 27, 2021 at 01:51:16PM +0200, Christoph Hellwig wrote:
> > On Mon, Sep 27, 2021 at 02:17:47PM +0800, Murphy Zhou wrote:
> > > Hi folks,
> > >
> > > Since this commit:
> > >
> > > commit edb0872f44ec9976ea6d052cb4b93cd2d23ac2ba
> > > Author: Christoph Hellwig <hch@lst.de>
> > > Date: Mon Aug 9 16:17:43 2021 +0200
> > >
> > > block: move the bdi from the request_queue to the gendisk
> > >
> > >
> > > Looping xfstests generic/108 or xfs/279 on mountpoints with fsdax
> > > enabled can lead to panic like this:
> >
> > Does this still happen with this series:
> >
> > https://lore.kernel.org/linux-block/20210922172222.2453343-1-hch@lst.de/T/#m8dc646a4dfc40f443227da6bb1c77d9daec524db
> >
> > ?
>
> My test machinse all hit this when writeback throttling is enabled, so
>
> Tested-by: Darrick J. Wong <djwong@kernel.org>
Thanks Darrick, I've added that.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [regression] fs dax xfstests panic
2021-09-27 23:02 ` Darrick J. Wong
2021-09-27 23:14 ` Dan Williams
@ 2021-09-28 4:34 ` Christoph Hellwig
2021-09-28 5:16 ` Darrick J. Wong
1 sibling, 1 reply; 8+ messages in thread
From: Christoph Hellwig @ 2021-09-28 4:34 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Christoph Hellwig, Murphy Zhou, nvdimm, linux-fsdevel
On Mon, Sep 27, 2021 at 04:02:59PM -0700, Darrick J. Wong wrote:
> > > Looping xfstests generic/108 or xfs/279 on mountpoints with fsdax
> > > enabled can lead to panic like this:
> >
> > Does this still happen with this series:
> >
> > https://lore.kernel.org/linux-block/20210922172222.2453343-1-hch@lst.de/T/#m8dc646a4dfc40f443227da6bb1c77d9daec524db
> >
> > ?
>
> My test machinse all hit this when writeback throttling is enabled, so
>
> Tested-by: Darrick J. Wong <djwong@kernel.org>
Do you mean the series fixed it for you?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [regression] fs dax xfstests panic
2021-09-28 4:34 ` Christoph Hellwig
@ 2021-09-28 5:16 ` Darrick J. Wong
2021-09-28 5:17 ` Christoph Hellwig
0 siblings, 1 reply; 8+ messages in thread
From: Darrick J. Wong @ 2021-09-28 5:16 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Murphy Zhou, nvdimm, linux-fsdevel
On Tue, Sep 28, 2021 at 06:34:26AM +0200, Christoph Hellwig wrote:
> On Mon, Sep 27, 2021 at 04:02:59PM -0700, Darrick J. Wong wrote:
> > > > Looping xfstests generic/108 or xfs/279 on mountpoints with fsdax
> > > > enabled can lead to panic like this:
> > >
> > > Does this still happen with this series:
> > >
> > > https://lore.kernel.org/linux-block/20210922172222.2453343-1-hch@lst.de/T/#m8dc646a4dfc40f443227da6bb1c77d9daec524db
> > >
> > > ?
> >
> > My test machinse all hit this when writeback throttling is enabled, so
> >
> > Tested-by: Darrick J. Wong <djwong@kernel.org>
>
> Do you mean the series fixed it for you?
Yes.
--D
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [regression] fs dax xfstests panic
2021-09-28 5:16 ` Darrick J. Wong
@ 2021-09-28 5:17 ` Christoph Hellwig
2021-09-28 5:20 ` Darrick J. Wong
0 siblings, 1 reply; 8+ messages in thread
From: Christoph Hellwig @ 2021-09-28 5:17 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Christoph Hellwig, Murphy Zhou, nvdimm, linux-fsdevel
On Mon, Sep 27, 2021 at 10:16:10PM -0700, Darrick J. Wong wrote:
> > > My test machinse all hit this when writeback throttling is enabled, so
> > >
> > > Tested-by: Darrick J. Wong <djwong@kernel.org>
> >
> > Do you mean the series fixed it for you?
>
> Yes.
Thanks! I was just a little confused this came in in this thread.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [regression] fs dax xfstests panic
2021-09-28 5:17 ` Christoph Hellwig
@ 2021-09-28 5:20 ` Darrick J. Wong
0 siblings, 0 replies; 8+ messages in thread
From: Darrick J. Wong @ 2021-09-28 5:20 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Murphy Zhou, nvdimm, linux-fsdevel
On Tue, Sep 28, 2021 at 07:17:00AM +0200, Christoph Hellwig wrote:
> On Mon, Sep 27, 2021 at 10:16:10PM -0700, Darrick J. Wong wrote:
> > > > My test machinse all hit this when writeback throttling is enabled, so
> > > >
> > > > Tested-by: Darrick J. Wong <djwong@kernel.org>
> > >
> > > Do you mean the series fixed it for you?
> >
> > Yes.
>
> Thanks! I was just a little confused this came in in this thread.
Yeah, I was too incoherent after arguing on #xfs to be able to form
complete sentences, sorry about that.
Also thank you for fixing this problem. :)
--D
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-28 5:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 6:17 [regression] fs dax xfstests panic Murphy Zhou
2021-09-27 11:51 ` Christoph Hellwig
2021-09-27 23:02 ` Darrick J. Wong
2021-09-27 23:14 ` Dan Williams
2021-09-28 4:34 ` Christoph Hellwig
2021-09-28 5:16 ` Darrick J. Wong
2021-09-28 5:17 ` Christoph Hellwig
2021-09-28 5:20 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).