From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D68D82CA5 for ; Mon, 31 Jan 2022 14:14:23 +0000 (UTC) Received: from fraeml737-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JnVMX4DGhz681B0; Mon, 31 Jan 2022 22:10:32 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml737-chm.china.huawei.com (10.206.15.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 31 Jan 2022 15:14:14 +0100 Received: from localhost (10.47.73.212) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.21; Mon, 31 Jan 2022 14:14:14 +0000 Date: Mon, 31 Jan 2022 14:14:08 +0000 From: Jonathan Cameron To: Dan Williams CC: , , Subject: Re: [PATCH v3 09/40] cxl/decoder: Hide physical address information from non-root Message-ID: <20220131141408.00004d4a@Huawei.com> In-Reply-To: <164298416650.3018233.450720006145238709.stgit@dwillia2-desk3.amr.corp.intel.com> References: <164298411792.3018233.7493009997525360044.stgit@dwillia2-desk3.amr.corp.intel.com> <164298416650.3018233.450720006145238709.stgit@dwillia2-desk3.amr.corp.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.73.212] X-ClientProxiedBy: lhreml704-chm.china.huawei.com (10.201.108.53) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected On Sun, 23 Jan 2022 16:29:26 -0800 Dan Williams wrote: > Just like /proc/iomem, CXL physical address information is reserved for > root only. > > Signed-off-by: Dan Williams Seems sensible. Reviewed-by: Jonathan Cameron > --- > drivers/cxl/core/port.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c > index 3f9b98ecd18b..c5e74c6f04e8 100644 > --- a/drivers/cxl/core/port.c > +++ b/drivers/cxl/core/port.c > @@ -49,7 +49,7 @@ static ssize_t start_show(struct device *dev, struct device_attribute *attr, > > return sysfs_emit(buf, "%#llx\n", cxld->range.start); > } > -static DEVICE_ATTR_RO(start); > +static DEVICE_ATTR_ADMIN_RO(start); > > static ssize_t size_show(struct device *dev, struct device_attribute *attr, > char *buf) >