From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-nvdimm-bounces@lists.01.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 2655921AE30DB
 for <linux-nvdimm@lists.01.org>; Mon, 24 Sep 2018 14:04:50 -0700 (PDT)
From: David Howells <dhowells@redhat.com>
In-Reply-To: <CAPcyv4j02Ts5J8CFHFVVioBYjHwr7cbsqrz3yTCm4Yoxf1CTOg@mail.gmail.com>
References: <CAPcyv4j02Ts5J8CFHFVVioBYjHwr7cbsqrz3yTCm4Yoxf1CTOg@mail.gmail.com>
 <153549632073.4089.3609134467249378610.stgit@djiang5-desk3.ch.intel.com>
 <153549644916.4089.12258485183075906901.stgit@djiang5-desk3.ch.intel.com>
Subject: Re: [PATCH v8 02/12] libnvdimm: create keyring to store security keys
MIME-Version: 1.0
Content-ID: <29623.1537823087.1@warthog.procyon.org.uk>
Date: Mon, 24 Sep 2018 22:04:47 +0100
Message-ID: <29624.1537823087@warthog.procyon.org.uk>
List-Unsubscribe: <https://lists.01.org/mailman/options/linux-nvdimm>,
 <mailto:linux-nvdimm-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/linux-nvdimm/>
List-Post: <mailto:linux-nvdimm@lists.01.org>
List-Help: <mailto:linux-nvdimm-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/linux-nvdimm>,
 <mailto:linux-nvdimm-request@lists.01.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: linux-nvdimm-bounces@lists.01.org
Sender: "Linux-nvdimm" <linux-nvdimm-bounces@lists.01.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Schofield, Alison  <alison.schofield@intel.com>, Kees Cook <keescook@chromium.org>, linux-nvdimm" <linux-nvdimm@lists.01.org>, Eric Biggers <ebiggers3@gmail.com>, dhowells@redhat.com, keyrings@vger.kernel.org
List-ID: <linux-nvdimm@lists.01.org>

Dan Williams <dan.j.williams@intel.com> wrote:

> I think you want to use prepare_kernel_cred(), not export init_cred.

That only works if the searching is done with the creds generated by
prepare_kernel_cred().  He probably does want init_cred, or at least
current_cred() if module loading overrides the creds with init_cred whilst
initialising the module.

David
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm