From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com (ale.deltatee.com [207.54.116.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 06FCE21163241 for ; Fri, 5 Oct 2018 08:42:15 -0700 (PDT) References: <20181004212747.6301-1-logang@deltatee.com> <20181004212747.6301-14-logang@deltatee.com> <2bcc0927-83ab-1bf2-d584-aebd5274cefa@deltatee.com> <20181005070720.GA23725@lst.de> From: Logan Gunthorpe Message-ID: <298e6e20-c8b6-de4b-46f5-94d1d3e2445c@deltatee.com> Date: Fri, 5 Oct 2018 09:42:05 -0600 MIME-Version: 1.0 In-Reply-To: <20181005070720.GA23725@lst.de> Content-Language: en-CA Subject: Re: [PATCH v9 13/13] nvmet: Optionally use PCI P2P memory List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Christoph Hellwig Cc: Jens Axboe , Alex Williamson , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, Steve Wise , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , =?UTF-8?Q?Christian_K=c3=b6nig?= List-ID: On 2018-10-05 1:07 a.m., Christoph Hellwig wrote: > On Thu, Oct 04, 2018 at 04:29:19PM -0600, Logan Gunthorpe wrote: >>> This needs to handle non bdev namespaces. >> >> As it's coded now the helper never gets called unless ns->bdev is not >> null. But in general, yes you are right, we should probably return NULL >> if ns->bdev is NULL. > > I'd rather skip that for now. Ok, if I do a v10 I'll add it but I don't have anything else queued up at the moment. >> Sure, I guess that makes sense. I've never tried it with fc hardware but >> I assume there's no reason it wouldn't work. >> >> I'll queue these changes up for a v10. > > And I'd wait until someone has actually tested this case. Agreed. Thanks for the review! Logan _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm