From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com (ale.deltatee.com [207.54.116.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4CC8E21148427 for ; Thu, 4 Oct 2018 15:29:31 -0700 (PDT) References: <20181004212747.6301-1-logang@deltatee.com> <20181004212747.6301-14-logang@deltatee.com> From: Logan Gunthorpe Message-ID: <2bcc0927-83ab-1bf2-d584-aebd5274cefa@deltatee.com> Date: Thu, 4 Oct 2018 16:29:19 -0600 MIME-Version: 1.0 In-Reply-To: Content-Language: en-CA Subject: Re: [PATCH v9 13/13] nvmet: Optionally use PCI P2P memory List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Sagi Grimberg , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org Cc: Jens Axboe , =?UTF-8?Q?Christian_K=c3=b6nig?= , Benjamin Herrenschmidt , Steve Wise , Alex Williamson , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-ID: On 2018-10-04 4:20 p.m., Sagi Grimberg wrote: >> +static inline struct device *nvmet_ns_dev(struct nvmet_ns *ns) >> +{ >> + return disk_to_dev(ns->bdev->bd_disk); >> +} > > This needs to handle non bdev namespaces. As it's coded now the helper never gets called unless ns->bdev is not null. But in general, yes you are right, we should probably return NULL if ns->bdev is NULL. > And this? > -- > diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c > index ef286b72d958..3d12f5f4568d 100644 > --- a/drivers/nvme/target/fc.c > +++ b/drivers/nvme/target/fc.c > @@ -2280,6 +2280,7 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport > *tgtport, > fod->req.cmd = &fod->cmdiubuf.sqe; > fod->req.rsp = &fod->rspiubuf.cqe; > fod->req.port = tgtport->pe->port; > + fod->req.p2p_client = tgtport->dev; > > /* clear any response payload */ > memset(&fod->rspiubuf, 0, sizeof(fod->rspiubuf)); > -- Sure, I guess that makes sense. I've never tried it with fc hardware but I assume there's no reason it wouldn't work. I'll queue these changes up for a v10. Logan _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm