From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 93FF2211435AC for ; Mon, 24 Sep 2018 14:15:57 -0700 (PDT) Subject: Re: [PATCH v8 02/12] libnvdimm: create keyring to store security keys References: <153549644916.4089.12258485183075906901.stgit@djiang5-desk3.ch.intel.com> <153549632073.4089.3609134467249378610.stgit@djiang5-desk3.ch.intel.com> <29481.1537822932@warthog.procyon.org.uk> From: Dave Jiang Message-ID: <3239afcc-eb4a-22f5-f45c-74842124cf7a@intel.com> Date: Mon, 24 Sep 2018 14:15:33 -0700 MIME-Version: 1.0 In-Reply-To: <29481.1537822932@warthog.procyon.org.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: David Howells Cc: alison.schofield@intel.com, keescook@chromium.org, linux-nvdimm@lists.01.org, ebiggers3@gmail.com, keyrings@vger.kernel.org List-ID: On 09/24/2018 02:02 PM, David Howells wrote: > Dave Jiang wrote: > >> + GLOBAL_ROOT_UID, GLOBAL_ROOT_GID, &init_cred, > > Hmmm... I wonder if current_cred() would suffice since you must be called > from something that has the ability to load modules. Further, I wonder if > module loading should be wrapped in an override with init_cred in the core. > >> + (KEY_USR_ALL & ~KEY_USR_SETATTR), > > Did you really want to give the user write access, btw? Hmmm....maybe I don't want user access at all since this is a kernel key ring? > > David > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm