nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] libnvdimm, namespace: Replace kmemdup() with kstrndup()
@ 2018-06-11 13:47 Andy Shevchenko
  2018-08-30 11:56 ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2018-06-11 13:47 UTC (permalink / raw)
  To: Dan Williams, Ross Zwisler, Vishal Verma, Dave Jiang, linux-nvdimm
  Cc: Andy Shevchenko

kstrndup() takes care of '\0' terminator for the strings.

Use it here instead of kmemdup() + explicit terminating the input string.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/nvdimm/namespace_devs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
index 28afdd668905..19525f025539 100644
--- a/drivers/nvdimm/namespace_devs.c
+++ b/drivers/nvdimm/namespace_devs.c
@@ -270,11 +270,10 @@ static ssize_t __alt_name_store(struct device *dev, const char *buf,
 	if (dev->driver || to_ndns(dev)->claim)
 		return -EBUSY;
 
-	input = kmemdup(buf, len + 1, GFP_KERNEL);
+	input = kstrndup(buf, len, GFP_KERNEL);
 	if (!input)
 		return -ENOMEM;
 
-	input[len] = '\0';
 	pos = strim(input);
 	if (strlen(pos) + 1 > NSLABEL_NAME_LEN) {
 		rc = -EINVAL;
-- 
2.17.1

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] libnvdimm, namespace: Replace kmemdup() with kstrndup()
  2018-06-11 13:47 [PATCH v1] libnvdimm, namespace: Replace kmemdup() with kstrndup() Andy Shevchenko
@ 2018-08-30 11:56 ` Andy Shevchenko
  2018-08-30 22:05   ` Dave Jiang
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2018-08-30 11:56 UTC (permalink / raw)
  To: Dan Williams, Ross Zwisler, Vishal Verma, Dave Jiang, linux-nvdimm

On Mon, Jun 11, 2018 at 04:47:21PM +0300, Andy Shevchenko wrote:
> kstrndup() takes care of '\0' terminator for the strings.
> 
> Use it here instead of kmemdup() + explicit terminating the input string.
> 

Any comments on this?

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/nvdimm/namespace_devs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
> index 28afdd668905..19525f025539 100644
> --- a/drivers/nvdimm/namespace_devs.c
> +++ b/drivers/nvdimm/namespace_devs.c
> @@ -270,11 +270,10 @@ static ssize_t __alt_name_store(struct device *dev, const char *buf,
>  	if (dev->driver || to_ndns(dev)->claim)
>  		return -EBUSY;
>  
> -	input = kmemdup(buf, len + 1, GFP_KERNEL);
> +	input = kstrndup(buf, len, GFP_KERNEL);
>  	if (!input)
>  		return -ENOMEM;
>  
> -	input[len] = '\0';
>  	pos = strim(input);
>  	if (strlen(pos) + 1 > NSLABEL_NAME_LEN) {
>  		rc = -EINVAL;
> -- 
> 2.17.1
> 

-- 
With Best Regards,
Andy Shevchenko


_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] libnvdimm, namespace: Replace kmemdup() with kstrndup()
  2018-08-30 11:56 ` Andy Shevchenko
@ 2018-08-30 22:05   ` Dave Jiang
  0 siblings, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2018-08-30 22:05 UTC (permalink / raw)
  To: Andy Shevchenko, Dan Williams, Ross Zwisler, Vishal Verma, linux-nvdimm



On 08/30/2018 04:56 AM, Andy Shevchenko wrote:
> On Mon, Jun 11, 2018 at 04:47:21PM +0300, Andy Shevchenko wrote:
>> kstrndup() takes care of '\0' terminator for the strings.
>>
>> Use it here instead of kmemdup() + explicit terminating the input string.
>>
> 
> Any comments on this?

Applied. Sorry looks like this one got missed.

> 
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>>  drivers/nvdimm/namespace_devs.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
>> index 28afdd668905..19525f025539 100644
>> --- a/drivers/nvdimm/namespace_devs.c
>> +++ b/drivers/nvdimm/namespace_devs.c
>> @@ -270,11 +270,10 @@ static ssize_t __alt_name_store(struct device *dev, const char *buf,
>>  	if (dev->driver || to_ndns(dev)->claim)
>>  		return -EBUSY;
>>  
>> -	input = kmemdup(buf, len + 1, GFP_KERNEL);
>> +	input = kstrndup(buf, len, GFP_KERNEL);
>>  	if (!input)
>>  		return -ENOMEM;
>>  
>> -	input[len] = '\0';
>>  	pos = strim(input);
>>  	if (strlen(pos) + 1 > NSLABEL_NAME_LEN) {
>>  		rc = -EINVAL;
>> -- 
>> 2.17.1
>>
> 
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-30 22:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-11 13:47 [PATCH v1] libnvdimm, namespace: Replace kmemdup() with kstrndup() Andy Shevchenko
2018-08-30 11:56 ` Andy Shevchenko
2018-08-30 22:05   ` Dave Jiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).