nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: Bart Van Assche <bvanassche@acm.org>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-block@vger.kernel.org
Cc: "Jens Axboe" <axboe@kernel.dk>,
	"Christian König" <christian.koenig@amd.com>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Jason Gunthorpe" <jgg@mellanox.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Max Gurtovoy" <maxg@mellanox.com>,
	"Christoph Hellwig" <hch@lst.de>
Subject: Re: [PATCH v7 01/13] PCI/P2PDMA: Support peer-to-peer memory
Date: Tue, 25 Sep 2018 12:09:31 -0600	[thread overview]
Message-ID: <3efcee21-e439-f6ed-230b-c52c4872f0d2@deltatee.com> (raw)
In-Reply-To: <1537896340.11137.19.camel@acm.org>



On 2018-09-25 11:25 a.m., Bart Van Assche wrote:
> It's great to see this patch series making progress. Unfortunately I didn't
> have the time earlier to have a closer look at this patch series. I hope that
> you don't mind that I ask a few questions about the implementation?

Thanks for the review Bart!

>> +static void pci_p2pdma_percpu_kill(void *data)
>> +{
>> +	struct percpu_ref *ref = data;
>> +
>> +	if (percpu_ref_is_dying(ref))
>> +		return;
>> +
>> +	percpu_ref_kill(ref);
>> +}
> 
> The percpu_ref_is_dying() test should either be removed or a comment should be
> added above it that explains why it is necessary. Is the purpose of that call
> perhaps to protect against multiple calls of pci_p2pdma_percpu_kill()? If so,
> which mechanism serializes these multiple calls?

Hmm, yes, this was copied from device DAX, but I see it has been removed
from there since then. I'll remove it for v8.

>> +static void pci_p2pdma_release(void *data)
>> +{
>> +	struct pci_dev *pdev = data;
>> +
>> +	if (!pdev->p2pdma)
>> +		return;
>> +
>> +	wait_for_completion(&pdev->p2pdma->devmap_ref_done);
>> +	percpu_ref_exit(&pdev->p2pdma->devmap_ref);
>> +
>> +	gen_pool_destroy(pdev->p2pdma->pool);
>> +	pdev->p2pdma = NULL;
>> +}
> 
> Which code frees the memory pdev->p2pdma points at? Other functions similar to
> pci_p2pdma_release() call devm_remove_action(), e.g. hmm_devmem_ref_exit().

pdev->p2pdma is allocated using devm so it will be freed when the PCI
driver is being unwound. pci_p2pdma_release() is a devm action itself
which is registered right after the devm_kzalloc() call. Therefore the
memory will be freed in the next devm action. I don't exactly know what
hmm is doing there but we don't have similar actions to remove.

>> +static int pci_p2pdma_setup(struct pci_dev *pdev)
>> +{
>> +	int error = -ENOMEM;
>> +	struct pci_p2pdma *p2p;
>> +
>> +	p2p = devm_kzalloc(&pdev->dev, sizeof(*p2p), GFP_KERNEL);
>> +	if (!p2p)
>> +		return -ENOMEM;
>> +
>> +	p2p->pool = gen_pool_create(PAGE_SHIFT, dev_to_node(&pdev->dev));
>> +	if (!p2p->pool)
>> +		goto out;
>> +
>> +	init_completion(&p2p->devmap_ref_done);
>> +	error = percpu_ref_init(&p2p->devmap_ref,
>> +			pci_p2pdma_percpu_release, 0, GFP_KERNEL);
>> +	if (error)
>> +		goto out_pool_destroy;
>> +
>> +	percpu_ref_switch_to_atomic_sync(&p2p->devmap_ref);
> 
> Why are percpu_ref_init() and percpu_ref_switch_to_atomic_sync() called
> separately instead of passing PERCPU_REF_INIT_ATOMIC to percpu_ref_init()?
> Would using PERCPU_REF_INIT_ATOMIC eliminate a call_rcu_sched() call and
> hence make this function faster?

I can't even remember why we are switching to atomic at all. It probably
shouldn't be there. I'll remove it for v8.


>> +static struct pci_dev *find_parent_pci_dev(struct device *dev)
>
> The above function increases the reference count of the device it returns a
> pointer to. It is a good habit to explain such behavior above the function
> definition.

Will do.

>> +static void seq_buf_print_bus_devfn(struct seq_buf *buf, struct pci_dev *pdev)
>> +{
>> +	if (!buf)
>> +		return;
>> +
>> +	seq_buf_printf(buf, "%s;", pci_name(pdev));
>> +}
> 
> NULL checks in functions that print to a seq buffer are unusual. Is it
> possible that a NULL pointer gets passed as the first argument to
> seq_buf_print_bus_devfn()?

Yes. There are two paths here one that's verbose and one that's not. In
the non-verbose case, we pass NULL instead of the seq_buf, so both calls
need to ensure the seq_buf is not NULL before trying to print to it.

>> +struct pci_p2pdma_client {
>> +	struct list_head list;
>> +	struct pci_dev *client;
>> +	struct pci_dev *provider;
>> +};
> 
> Is there a reason that the peer-to-peer client and server code exist in the
> same source file? If not, have you considered to split the p2pdma.c file into
> two files - one with the code for devices that provide p2p functionality and
> another file with the code that supports p2p users? I think that would make it
> easier to follow the code.

I see what you're saying but generally I get push back against adding
extra files. I'm going to leave it the way it is unless other people
voice their opinions in favour of the change.

>> +/**
>> + * pci_free_p2pmem - allocate peer-to-peer DMA memory
>> + * @pdev: the device the memory was allocated from
>> + * @addr: address of the memory that was allocated
>> + * @size: number of bytes that was allocated
>> + */
>> +void pci_free_p2pmem(struct pci_dev *pdev, void *addr, size_t size)
>> +{
>> +	gen_pool_free(pdev->p2pdma->pool, (uintptr_t)addr, size);
>> +	percpu_ref_put(&pdev->p2pdma->devmap_ref);
>> +}
>> +EXPORT_SYMBOL_GPL(pci_free_p2pmem);
> 
> Please fix the header of this function - there is a copy-paste error in the
> function header.

Will do.

Logan
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2018-09-25 18:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 16:22 [PATCH v7 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 01/13] PCI/P2PDMA: Support peer-to-peer memory Logan Gunthorpe
2018-09-25 17:25   ` Bart Van Assche
2018-09-25 18:09     ` Logan Gunthorpe [this message]
2018-09-25 16:22 ` [PATCH v7 02/13] PCI/P2PDMA: Add sysfs group to display p2pmem stats Logan Gunthorpe
2018-09-25 17:29   ` Bart Van Assche
2018-09-25 18:15     ` Logan Gunthorpe
2018-09-25 18:31       ` Bart Van Assche
2018-09-25 18:51         ` Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 03/13] PCI/P2PDMA: Add PCI p2pmem DMA mappings to adjust the bus offset Logan Gunthorpe
2018-09-25 17:33   ` Bart Van Assche
2018-09-25 18:46     ` Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 04/13] PCI/P2PDMA: Introduce configfs/sysfs enable attribute helpers Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 05/13] docs-rst: Add a new directory for PCI documentation Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 06/13] PCI/P2PDMA: Add P2P DMA driver writer's documentation Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 07/13] block: Add PCI P2P flag for request queue and check support for requests Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 08/13] IB/core: Ensure we map P2P memory correctly in rdma_rw_ctx_[init|destroy]() Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 09/13] nvme-pci: Use PCI p2pmem subsystem to manage the CMB Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 10/13] nvme-pci: Add support for P2P memory in requests Logan Gunthorpe
2018-09-25 17:11   ` Keith Busch
2018-09-25 17:41     ` Logan Gunthorpe
2018-09-25 17:48       ` Keith Busch
2018-09-25 16:22 ` [PATCH v7 11/13] nvme-pci: Add a quirk for a pseudo CMB Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 12/13] nvmet: Introduce helper functions to allocate and free request SGLs Logan Gunthorpe
2018-09-25 16:22 ` [PATCH v7 13/13] nvmet: Optionally use PCI P2P memory Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3efcee21-e439-f6ed-230b-c52c4872f0d2@deltatee.com \
    --to=logang@deltatee.com \
    --cc=alex.williamson@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=bvanassche@acm.org \
    --cc=christian.koenig@amd.com \
    --cc=hch@lst.de \
    --cc=jgg@mellanox.com \
    --cc=jglisse@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=maxg@mellanox.com \
    --subject='Re: [PATCH v7 01/13] PCI/P2PDMA: Support peer-to-peer memory' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).