From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E255217F for ; Sun, 23 May 2021 07:54:07 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621756446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/MSb7WB4yg0xY//iJ4g4o9OrazLUgapaBmCSPU09/w=; b=FC/3WRGmbKLV9khHIpTe9yyXvRUN7xxss53zAKWt+qPq7bC39y/+TOpVowgKFbkdqtgN39 wIZQxHHjp89jEnloHEengHgD8PZOwsgYN9EAyuhMu7q7ZSb7lghFKiZG3iD2USft6npSCy eNVry1lTEz7fFddLBqOGiCa8FzH8fGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621756446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/MSb7WB4yg0xY//iJ4g4o9OrazLUgapaBmCSPU09/w=; b=uBPd4XPXbURZPUEYY7Ti50Vf8xHvPCvMBcQoB+74ddrgR7/RrWEsplxLKlp80m4Ht7bEh7 40Kbf475wc2SC2DA== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 31E2BAB6D; Sun, 23 May 2021 07:54:06 +0000 (UTC) Subject: Re: [PATCH 04/26] block: add a flag to make put_disk on partially initalized disks safer To: Christoph Hellwig , Jens Axboe , Geert Uytterhoeven , Chris Zankel , Max Filippov , Philipp Reisner , Lars Ellenberg , Jim Paris , Philip Kelleher , Minchan Kim , Nitin Gupta , Matias Bjorling , Coly Li , Mike Snitzer , Song Liu , Maxim Levitsky , Alex Dubov , Ulf Hansson , Dan Williams , Vishal Verma , Dave Jiang , Heiko Carstens , Vasily Gorbik , Christian Borntraeger Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linuxppc-dev@lists.ozlabs.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org References: <20210521055116.1053587-1-hch@lst.de> <20210521055116.1053587-5-hch@lst.de> From: Hannes Reinecke Message-ID: <4526cf9d-1735-9517-c5c6-1d851d15d0ab@suse.de> Date: Sun, 23 May 2021 09:54:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210521055116.1053587-5-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/21/21 7:50 AM, Christoph Hellwig wrote: > Add a flag to indicate that __device_add_disk did grab a queue reference > so that disk_release only drops it if we actually had it. This sort > out one of the major pitfals with partially initialized gendisk that pitfalls > a lot of drivers did get wrong or still do. > > Signed-off-by: Christoph Hellwig > --- > block/genhd.c | 7 +++++-- > include/linux/genhd.h | 1 + > 2 files changed, 6 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer