nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Qi, Fuli" <qi.fuli@jp.fujitsu.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [RFC PATCH v4] ndctl: monitor: add ndctl monitor daemon
Date: Thu, 15 Mar 2018 19:41:06 +0900	[thread overview]
Message-ID: <58684e81-ac3a-718e-a717-0a1b54766100@jp.fujitsu.com> (raw)
In-Reply-To: <CAPcyv4jPghKyQ6AuVJ-R=fiKcQufzHs-DExzcyHTbshF-2bq1Q@mail.gmail.com>

>> In this implemention, when a ndctl monitor starts with [--daemon] option, all
>> the arguments will be saved into a temp file named as daemon-name and placed
>> under /etc/sysconfig/ndctl/ directory. The temp file would be used as an
>> EnvironmentFile by systemd, and it would be deleted automatically when the
>> systemd service is stopped.
> The monitors started by hand should be kept separate from the monitors
> started by systemd. The default monitor started by systemd should get
> its configuration from /etc/ndctl.conf, and we should otherwise have a
> --conf-file option to the monitor to override the default
> configuration. Any other monitors started outside of the systemd
> should remain independent.
Thank you very much for your comments. I still have something unclear about
how to manage ndctl monitor daemon. Let's clarify the specification of 
monitor daemon.

I have the following questions.
  a) About command line interface
     1) I would like to confirm when a monitor daemon is launched  by using
        command line interface with [--daemon] option (like # ndctl monitor
        --dimm nmem1 --daemon), then how to manage it? (i.e. stop, check 
     2) When multiple daemons be running at same time, how can we recognize
        each of them?

  b) About using systemctl command
     3) Should we need to limit the maximum number of running daemons to 
be one?
        If yes, I am thinking the option should support multiple values, 
        users can modify the default configuration by using 
[--conf-file] option.
        # ndctl monitor --dimm nmem1,nmem2 --conf-file

     4) If multiple daemons can be running at the same time, multiple 
        files named <daemon-name> are needed. Do you agree that let 
users create the
        configuration file manually when they want to launch a monitor 
>> Due to the deletion the following commands will not work.
>> # systemctl enable ndctl-monitor@daemon-name.service
>> # systemctl restart ndctl-monitor@daemon-name.service
>> I am not sure whether these commands are needed for ndctl monitor daemon,
>> your comments will be appreciated.
> Both those commands are needed.

Linux-nvdimm mailing list

  reply	other threads:[~2018-03-15 10:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 11:33 [RFC PATCH v4] ndctl: monitor: add ndctl monitor daemon QI Fuli
2018-03-14 18:19 ` Dan Williams
2018-03-15 10:41   ` Qi, Fuli [this message]
2018-03-16  1:03     ` Dan Williams
2018-03-16  7:33       ` Yasunori Goto
2018-03-16 10:01         ` Qi, Fuli
2018-03-16  6:55   ` Yasunori Goto
2018-03-16 13:28     ` Dan Williams
2018-03-17  0:23       ` Yasunori Goto
2018-03-19 11:27   ` Qi, Fuli
2018-03-19 14:27     ` Dan Williams
2018-03-20  1:03       ` Qi, Fuli
2018-03-29 10:02   ` Qi, Fuli
2018-03-29 22:59     ` Dan Williams
2018-03-30  7:34       ` Qi, Fuli
2018-03-30 16:34         ` Dan Williams
2018-04-02  0:10           ` Qi, Fuli
2018-04-05 23:17       ` Qi, Fuli
2018-04-06 19:02         ` Dan Williams
2018-04-09  8:38           ` Qi, Fuli
2018-04-09 17:45             ` Dan Williams
2018-04-10  2:15               ` Qi, Fuli
2018-04-10  3:06               ` Verma, Vishal L
2018-04-04 14:28     ` Jeff Moyer
2018-04-05 21:08       ` Qi, Fuli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58684e81-ac3a-718e-a717-0a1b54766100@jp.fujitsu.com \
    --to=qi.fuli@jp.fujitsu.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-nvdimm@lists.01.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).