* Re: [ndctl V5 4/4] Use page size as alignment value [not found] ` <27307f1aceeda53154b9985f065fdada71cf1fd4.camel@intel.com> @ 2021-05-26 19:31 ` Verma, Vishal L 2021-05-26 19:32 ` Verma, Vishal L 0 siblings, 1 reply; 3+ messages in thread From: Verma, Vishal L @ 2021-05-26 19:31 UTC (permalink / raw) To: nvdimm, santosh; +Cc: sbhat, harish, aneesh.kumar On Thu, 2021-05-13 at 18:17 +0000, Verma, Vishal L wrote: > On Thu, 2021-05-13 at 11:42 +0530, Santosh Sivaraj wrote: > > The alignment sizes passed to ndctl in the tests are all hardcoded to 4k, > > the default page size on x86. Change those to the default page size on that > > architecture (sysconf/getconf). No functional changes otherwise. > > > > Signed-off-by: Santosh Sivaraj <santosh@fossix.org> > > --- > > test/dpa-alloc.c | 15 ++++++++------- > > test/multi-dax.sh | 6 ++++-- > > test/sector-mode.sh | 4 +++- > > 3 files changed, 15 insertions(+), 10 deletions(-) > > Thanks for the updates, these look good - I've applied them and pushed > out on 'pending'. > > Hi Santosh, Dan noticed that this patch[1] got dropped from the series - just making sure that was intentional? Thanks, -Vishal ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ndctl V5 4/4] Use page size as alignment value 2021-05-26 19:31 ` [ndctl V5 4/4] Use page size as alignment value Verma, Vishal L @ 2021-05-26 19:32 ` Verma, Vishal L 2021-05-27 0:28 ` Santosh Sivaraj 0 siblings, 1 reply; 3+ messages in thread From: Verma, Vishal L @ 2021-05-26 19:32 UTC (permalink / raw) To: nvdimm, santosh; +Cc: sbhat, harish, aneesh.kumar On Wed, 2021-05-26 at 19:31 +0000, Verma, Vishal L wrote: > On Thu, 2021-05-13 at 18:17 +0000, Verma, Vishal L wrote: > > On Thu, 2021-05-13 at 11:42 +0530, Santosh Sivaraj wrote: > > > The alignment sizes passed to ndctl in the tests are all hardcoded to 4k, > > > the default page size on x86. Change those to the default page size on that > > > architecture (sysconf/getconf). No functional changes otherwise. > > > > > > Signed-off-by: Santosh Sivaraj <santosh@fossix.org> > > > --- > > > test/dpa-alloc.c | 15 ++++++++------- > > > test/multi-dax.sh | 6 ++++-- > > > test/sector-mode.sh | 4 +++- > > > 3 files changed, 15 insertions(+), 10 deletions(-) > > > > Thanks for the updates, these look good - I've applied them and pushed > > out on 'pending'. > > > > > Hi Santosh, > > Dan noticed that this patch[1] got dropped from the series - just > making sure that was intentional? Oops, hit send too early. [1]: https://lore.kernel.org/linux-nvdimm/20201222042516.2984348-4-santosh@fossix.org/ > > Thanks, > -Vishal ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ndctl V5 4/4] Use page size as alignment value 2021-05-26 19:32 ` Verma, Vishal L @ 2021-05-27 0:28 ` Santosh Sivaraj 0 siblings, 0 replies; 3+ messages in thread From: Santosh Sivaraj @ 2021-05-27 0:28 UTC (permalink / raw) To: Verma, Vishal L, nvdimm; +Cc: sbhat, harish, aneesh.kumar "Verma, Vishal L" <vishal.l.verma@intel.com> writes: Hi Vishal, > On Wed, 2021-05-26 at 19:31 +0000, Verma, Vishal L wrote: >> On Thu, 2021-05-13 at 18:17 +0000, Verma, Vishal L wrote: >> > On Thu, 2021-05-13 at 11:42 +0530, Santosh Sivaraj wrote: >> > > The alignment sizes passed to ndctl in the tests are all hardcoded to 4k, >> > > the default page size on x86. Change those to the default page size on that >> > > architecture (sysconf/getconf). No functional changes otherwise. >> > > >> > > Signed-off-by: Santosh Sivaraj <santosh@fossix.org> >> > > --- >> > > test/dpa-alloc.c | 15 ++++++++------- >> > > test/multi-dax.sh | 6 ++++-- >> > > test/sector-mode.sh | 4 +++- >> > > 3 files changed, 15 insertions(+), 10 deletions(-) >> > >> > Thanks for the updates, these look good - I've applied them and pushed >> > out on 'pending'. >> > >> > >> Hi Santosh, >> >> Dan noticed that this patch[1] got dropped from the series - just >> making sure that was intentional? Yes, that's right. It is intentional. The support SMART test cases are here[1] sent by Shiva, which I have combined with error injection test and sent as one patch series. [1]: https://lkml.kernel.org/r/20210517084259.181236-1-santosh@fossix.org Thanks, Santosh > > Oops, hit send too early. > > [1]: https://lore.kernel.org/linux-nvdimm/20201222042516.2984348-4-santosh@fossix.org/ > >> >> Thanks, >> -Vishal ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-27 0:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210513061218.760322-1-santosh@fossix.org>
[not found] ` <20210513061218.760322-4-santosh@fossix.org>
[not found] ` <27307f1aceeda53154b9985f065fdada71cf1fd4.camel@intel.com>
2021-05-26 19:31 ` [ndctl V5 4/4] Use page size as alignment value Verma, Vishal L
2021-05-26 19:32 ` Verma, Vishal L
2021-05-27 0:28 ` Santosh Sivaraj
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).