nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Zhang,Yi" <yi.z.zhang@linux.intel.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvdimm@lists.01.org, pbonzini@redhat.com,
	dan.j.williams@intel.com, jack@suse.cz, hch@lst.de,
	yu.c.zhang@intel.com
Cc: linux-mm@kvack.org, yi.z.zhang@intel.com, rkrcmar@redhat.com
Subject: Re: [PATCH V2 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio
Date: Fri, 13 Jul 2018 22:29:09 +0800	[thread overview]
Message-ID: <6c0fea06-d52e-9bc4-c690-581b1d6f3cd3@linux.intel.com> (raw)
In-Reply-To: <cover.1531241281.git.yi.z.zhang@linux.intel.com>

Ping for further review, comments.

Thanks All

Regards
Yi.

On 2018年07月11日 01:01, Zhang Yi wrote:
> For device specific memory space, when we move these area of pfn to
> memory zone, we will set the page reserved flag at that time, some of
> these reserved for device mmio, and some of these are not, such as
> NVDIMM pmem.
>
> Now, we map these dev_dax or fs_dax pages to kvm for DIMM/NVDIMM
> backend, since these pages are reserved. the check of
> kvm_is_reserved_pfn() misconceives those pages as MMIO. Therefor, we
> introduce 2 page map types, MEMORY_DEVICE_FS_DAX/MEMORY_DEVICE_DEV_DAX,
> to indentify these pages are from NVDIMM pmem. and let kvm treat these
> as normal pages.
>
> Without this patch, Many operations will be missed due to this
> mistreatment to pmem pages. For example, a page may not have chance to
> be unpinned for KVM guest(in kvm_release_pfn_clean); not able to be
> marked as dirty/accessed(in kvm_set_pfn_dirty/accessed) etc.
>
> V1:
> https://lkml.org/lkml/2018/7/4/91
>
> V2:
> *Add documentation for MEMORY_DEVICE_DEV_DAX memory type in comment block
> *Add is_dax_page() in mm.h to differentiate the pages is from DAX device.
> *Remove the function kvm_is_nd_pfn().
>
> Zhang Yi (4):
>   kvm: remove redundant reserved page check
>   mm: introduce memory type MEMORY_DEVICE_DEV_DAX
>   mm: add a function to differentiate the pages is from DAX device
>     memory
>   kvm: add a check if pfn is from NVDIMM pmem.
>
>  drivers/dax/pmem.c       |  1 +
>  include/linux/memremap.h |  9 +++++++++
>  include/linux/mm.h       | 12 ++++++++++++
>  virt/kvm/kvm_main.c      | 16 ++++++++--------
>  4 files changed, 30 insertions(+), 8 deletions(-)
>

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2018-07-13  6:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10 17:01 [PATCH V2 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang Yi
2018-07-10 17:01 ` [PATCH V2 1/4] kvm: remove redundant reserved page check Zhang Yi
2018-07-10 17:01 ` [PATCH V2 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-08-07  9:11   ` Jan Kara
2018-08-08  9:22     ` Zhang,Yi
2018-07-10 17:03 ` [PATCH V2 3/4] mm: add a function to differentiate the pages is from DAX device memory Zhang Yi
2018-08-07  9:13   ` Jan Kara
     [not found] ` <cover.1531241281.git.yi.z.zhang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-07-10 17:03   ` Zhang Yi
2018-07-10 17:04 ` [PATCH V2 4/4] kvm: add a check if pfn is from NVDIMM pmem Zhang Yi
2018-07-13 14:29 ` Zhang,Yi [this message]
2018-07-20 14:11 ` [PATCH V2 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang,Yi
2018-07-20  8:32   ` Paolo Bonzini
2018-07-20 16:24     ` Zhang,Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c0fea06-d52e-9bc4-c690-581b1d6f3cd3@linux.intel.com \
    --to=yi.z.zhang@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=yi.z.zhang@intel.com \
    --cc=yu.c.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).