From: "Williams, Dan J" <dan.j.williams@intel.com>
To: "hch@lst.de" <hch@lst.de>
Cc: lkp <lkp@intel.com>, "hare@suse.de" <hare@suse.de>,
"olkuroch@cisco.com" <olkuroch@cisco.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"lkp@lists.01.org" <lkp@lists.01.org>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"Sang,"@ml01.01.org, Oliver@ml01.01.org,
" <oliver.sang@intel.com>,
"@ml01.01.org, martin.petersen@oracle.com
Subject: Re: [block] 52f019d43c: ndctl.test-libndctl.fail
Date: Sat, 6 Mar 2021 20:33:04 +0000 [thread overview]
Message-ID: <6f40b1f53c029788e20fe175618d8772e36d648c.camel@intel.com> (raw)
In-Reply-To: <20210305074204.GA17414@lst.de>
On Fri, 2021-03-05 at 08:42 +0100, Christoph Hellwig wrote:
> Dan,
>
> can you make any sense of thos report?
[..]
> > check_set_config_data: dimm: 0 read2 data miscompare: 0
> > check_set_config_data: dimm: 0x1 read2 data miscompare: 0
> > check_set_config_data: dimm: 0x100 read2 data miscompare: 0
> > check_set_config_data: dimm: 0x101 read2 data miscompare: 0
> > check_dax_autodetect: dax_ndns: 0x558a74d92f00 ndns: 0x558a74d92f00
> > check_dax_autodetect: dax_ndns: 0x558a74d91f40 ndns: 0x558a74d91f40
> > check_pfn_autodetect: pfn_ndns: 0x558a74d91f40 ndns: 0x558a74d91f40
> > check_pfn_autodetect: pfn_ndns: 0x558a74d8c5e0 ndns: 0x558a74d8c5e0
> > check_btt_autodetect: btt_ndns: 0x558a74d8c5e0 ndns: 0x558a74d8c5e0
> > check_btt_autodetect: btt_ndns: 0x558a74da1390 ndns: 0x558a74da1390
> > check_btt_autodetect: btt_ndns: 0x558a74d8c5e0 ndns: 0x558a74d8c5e0
> > check_btt_autodetect: btt_ndns: 0x558a74d91f40 ndns: 0x558a74d91f40
> > namespace7.0: failed to write /dev/pmem7
> > check_namespaces: namespace7.0 validate_bdev failed
> > ndctl-test1 failed: -6
> > libkmod: ERROR ../libkmod/libkmod-module.c:793 kmod_module_remove_module: could not remove 'nfit_test': Resource temporarily unavailable
> > test-libndctl: FAIL
Yes, it looks like my unit test checks for exactly the behavior you
changed. It was convenient to test that the device could be switched
back to rw via BLKROSET, but I don't require that. The new behaviour of
letting the disk->ro take precedence makes more sense to me, so I'll
update the test for the new behaviour.
I.e. I don't think regressing a unit test counts as a userspace
regression.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2021-03-06 20:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210305055900.GC31481@xsang-OptiPlex-9020>
2021-03-05 7:42 ` [block] 52f019d43c: ndctl.test-libndctl.fail Christoph Hellwig
2021-03-05 14:38 ` Jeff Moyer
2021-03-06 20:33 ` Williams, Dan J [this message]
2021-03-08 7:09 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f40b1f53c029788e20fe175618d8772e36d648c.camel@intel.com \
--to=dan.j.williams@intel.com \
--cc=" <oliver.sang@intel.com>, "@ml01.01.org \
--cc="Sang,"@ml01.01.org \
--cc=Oliver@ml01.01.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=olkuroch@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).