nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Kani, Toshi" <toshi.kani@hpe.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: open sets ext4_da_aops for DAX existing files
Date: Fri, 7 Sep 2018 21:23:19 +0000	[thread overview]
Message-ID: <76e07643e9c36e4273588bd3e7f29d1393de4c3d.camel@hpe.com> (raw)

I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX
mounted ext4 files.  Looking at open() path:

New file
--------
  lookup_open
    ext4_create
      __ext4_new_inode
        ext4_set_inode_flags   // Set S_DAX flag
      ext4_set_aops            // Set aops to ext4_dax_aops

Existing file
-------------
  lookup_open
    ext4_lookup
      ext4_iget
        ext4_set_aops          // Set aops to ext4_da_aops
        ext4_set_inode_flags   // Set S_DAX flag

So, we set ext4_da_aops for existing files since S_DAX flag is set after
ext4_set_aops().

Thanks,
-Toshi


_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

             reply	other threads:[~2018-09-07 21:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 21:23 Kani, Toshi [this message]
2018-09-10 12:54 ` open sets ext4_da_aops for DAX existing files Jeff Moyer
2018-09-10 14:21   ` Kani, Toshi
2018-09-10 14:26     ` Dan Williams
2018-09-10 14:29 ` Jan Kara
2018-09-10 14:51   ` Kani, Toshi
2018-09-10 17:58     ` Elliott, Robert (Persistent Memory)
2018-09-11 15:27       ` Jan Kara
2018-09-11 16:34         ` Kani, Toshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76e07643e9c36e4273588bd3e7f29d1393de4c3d.camel@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).