From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"willy@infradead.org" <willy@infradead.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH 0/4] Remove nrexceptional tracking
Date: Thu, 6 Aug 2020 19:44:54 +0000 [thread overview]
Message-ID: <898e058f12c7340703804ed9d05df5ead9ecb50d.camel@intel.com> (raw)
In-Reply-To: <20200804161755.10100-1-willy@infradead.org>
On Tue, 2020-08-04 at 17:17 +0100, Matthew Wilcox (Oracle) wrote:
> We actually use nrexceptional for very little these days. It's a
> constant
> source of pain with the THP patches because we don't know how large a
> shadow entry is, so either we have to ask the xarray how many indices
> it covers, or store that information in the shadow entry (and reduce
> the amount of other information in the shadow entry proportionally).
> While tracking down the most recent case of "evict tells me I've got
> the accounting wrong again", I wondered if it might not be simpler to
> just remove it. So here's a patch set to do just that. I think each
> of these patches is an improvement in isolation, but the combination
> of
> all four is larger than the sum of its parts.
>
> I'm running xfstests on this patchset right now. If one of the DAX
> people could try it out, that'd be fantastic.
>
> Matthew Wilcox (Oracle) (4):
> mm: Introduce and use page_cache_empty
> mm: Stop accounting shadow entries
> dax: Account DAX entries as nrpages
> mm: Remove nrexceptional from inode
Hi Matthew,
I applied these on top of 5.8 and ran them through the nvdimm unit test
suite, and saw some test failures. The first failing test signature is:
+ umount test_dax_mnt
./dax-ext4.sh: line 62: 15749 Segmentation fault umount $MNT
FAIL dax-ext4.sh (exit status: 139)
The line is: https://github.com/pmem/ndctl/blob/master/test/dax.sh#L79
And the failing umount happens right after 'run_test', which calls this:
https://github.com/pmem/ndctl/blob/master/test/dax-pmd.c
>
> fs/block_dev.c | 2 +-
> fs/dax.c | 8 ++++----
> fs/inode.c | 2 +-
> include/linux/fs.h | 2 --
> include/linux/pagemap.h | 5 +++++
> mm/filemap.c | 15 ---------------
> mm/truncate.c | 19 +++----------------
> mm/workingset.c | 1 -
> 8 files changed, 14 insertions(+), 40 deletions(-)
>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-08-06 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 16:17 [PATCH 0/4] Remove nrexceptional tracking Matthew Wilcox (Oracle)
2020-08-04 16:17 ` [PATCH 1/4] mm: Introduce and use page_cache_empty Matthew Wilcox (Oracle)
2020-08-06 23:24 ` Kirill A. Shutemov
2020-08-16 1:48 ` Matthew Wilcox
2020-08-04 16:17 ` [PATCH 2/4] mm: Stop accounting shadow entries Matthew Wilcox (Oracle)
2020-08-04 16:17 ` [PATCH 3/4] dax: Account DAX entries as nrpages Matthew Wilcox (Oracle)
2020-08-04 16:17 ` [PATCH 4/4] mm: Remove nrexceptional from inode Matthew Wilcox (Oracle)
2020-08-06 19:44 ` Verma, Vishal L [this message]
2020-08-06 20:16 ` [PATCH 0/4] Remove nrexceptional tracking Verma, Vishal L
2020-10-08 19:33 ` Matthew Wilcox
2020-10-09 23:04 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=898e058f12c7340703804ed9d05df5ead9ecb50d.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).