From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA83021148427 for ; Thu, 4 Oct 2018 16:02:20 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [ndctl PATCH] libndctl: set errno for routines that don't return an error status Date: Thu, 4 Oct 2018 23:01:56 +0000 Message-ID: <9bd7c5c4d9f389706bfcd13e9cd8b1632afbd6df.camel@intel.com> References: <20181004223412.17403-1-vishal.l.verma@intel.com> <1dace9aed7cd223fc4e206e69b98b58c947fec17.camel@intel.com> In-Reply-To: <1dace9aed7cd223fc4e206e69b98b58c947fec17.camel@intel.com> Content-Language: en-US Content-ID: <3145AF8A6439494496BD223F7EC5BA11@intel.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "linux-nvdimm@lists.01.org" List-ID: On Thu, 2018-10-04 at 15:54 -0700, Williams, Dan J wrote: > On Thu, 2018-10-04 at 16:34 -0600, Vishal Verma wrote: > > For routines that return a UINT_MAX or UL{L}ONG_MAX, there isn't a > > way > > to get any information as to what went wrong. Set errno in such > > routines > > so that the callers can get some additional context about the > > error. > > Looks ok, but why EOVERFLOW and not ENOMEM for the out of resource > conditions? I debated between that and also ENOSPC, but nothing seemed like an exact fit for a buffer too small.. Mainly not ENOMEM because we aren't actually trying to allocate memory as a part of this? _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm