From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org
Cc: darrick.wong@oracle.com, willy@infradead.org, jack@suse.cz,
viro@zeniv.linux.org.uk, linux-btrfs@vger.kernel.org,
ocfs2-devel@oss.oracle.com, david@fromorbit.com, hch@lst.de,
rgoldwyn@suse.de
Subject: Re: [PATCH v3 03/10] fsdax: Output address in dax_iomap_pfn() and rename it
Date: Tue, 23 Mar 2021 21:24:19 +0530 [thread overview]
Message-ID: <9cf456a0-e2ce-18b2-100a-80604862831b@linux.ibm.com> (raw)
In-Reply-To: <20210319015237.993880-4-ruansy.fnst@fujitsu.com>
On 3/19/21 7:22 AM, Shiyang Ruan wrote:
> Add address output in dax_iomap_pfn() in order to perform a memcpy() in
> CoW case. Since this function both output address and pfn, rename it to
> dax_iomap_direct_access().
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/dax.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
Like the naming convention. It is consistent with
dax_direct_access() function.
Changes looks good to me. Feel free to add.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2021-03-23 15:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 1:52 [PATCH v3 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax Shiyang Ruan
2021-03-19 1:52 ` [PATCH v3 01/10] fsdax: Factor helpers to simplify dax fault code Shiyang Ruan
2021-03-23 15:33 ` Ritesh Harjani
2021-03-19 1:52 ` [PATCH v3 02/10] fsdax: Factor helper: dax_fault_actor() Shiyang Ruan
2021-03-23 15:48 ` Ritesh Harjani
2021-03-31 3:57 ` ruansy.fnst
2021-04-02 7:47 ` Christoph Hellwig
2021-03-19 1:52 ` [PATCH v3 03/10] fsdax: Output address in dax_iomap_pfn() and rename it Shiyang Ruan
2021-03-23 15:54 ` Ritesh Harjani [this message]
2021-03-19 1:52 ` [PATCH v3 04/10] fsdax: Introduce dax_iomap_cow_copy() Shiyang Ruan
2021-03-23 16:08 ` Ritesh Harjani
2021-03-19 1:52 ` [PATCH v3 05/10] fsdax: Replace mmap entry in case of CoW Shiyang Ruan
2021-04-01 6:39 ` Ritesh Harjani
2021-04-01 7:03 ` ruansy.fnst
2021-03-19 1:52 ` [PATCH v3 06/10] fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero Shiyang Ruan
2021-04-01 6:45 ` Ritesh Harjani
2021-04-01 7:00 ` ruansy.fnst
2021-03-19 1:52 ` [PATCH v3 07/10] iomap: Introduce iomap_apply2() for operations on two files Shiyang Ruan
2021-04-01 7:12 ` Ritesh Harjani
2021-03-19 1:52 ` [PATCH v3 08/10] fsdax: Dedup file range to use a compare function Shiyang Ruan
2021-04-01 11:11 ` Ritesh Harjani
2021-04-08 3:21 ` ruansy.fnst
2021-03-19 1:52 ` [PATCH v3 09/10] fs/xfs: Handle CoW for fsdax write() path Shiyang Ruan
2021-03-19 1:52 ` [PATCH v3 10/10] fs/xfs: Add dedupe support for fsdax Shiyang Ruan
2021-03-23 15:27 ` [PATCH v3 00/10] fsdax,xfs: Add reflink&dedupe " Ritesh Harjani
2021-04-02 7:49 ` Christoph Hellwig
2021-04-02 8:18 ` ruansy.fnst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cf456a0-e2ce-18b2-100a-80604862831b@linux.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=rgoldwyn@suse.de \
--cc=ruansy.fnst@fujitsu.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).