From: Andreas Dilger <adilger@dilger.ca>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@infradead.org>,
Xiong Zhou <xzhou@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Eric Sandeen <sandeen@sandeen.net>,
fstests <fstests@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: ioctl FIBMAP for dax gone in v4.17-rc1
Date: Tue, 17 Apr 2018 11:40:00 -0600 [thread overview]
Message-ID: <BE1492A6-DF52-428C-A3CE-E91F0ACC0ADA@dilger.ca> (raw)
In-Reply-To: <20180417165756.GC24738@magnolia>
[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]
On Apr 17, 2018, at 10:57 AM, Darrick J. Wong <darrick.wong@oracle.com> wrote:
>
> On Tue, Apr 17, 2018 at 09:53:47AM -0700, Dan Williams wrote:
>> On Tue, Apr 17, 2018 at 9:10 AM, Christoph Hellwig <hch@infradead.org> wrote:
>>> On Tue, Apr 17, 2018 at 10:40:59PM +0800, Xiong Zhou wrote:
>>>> We got these in v4.17-rc1:
>>>> 6e2608d xfs, dax: introduce xfs_dax_aops
>>>> fb094c9 ext2, dax: introduce ext2_dax_aops
>>>> 5f0663b ext4, dax: introduce ext4_dax_aops
>>>>
>>>> And we don't have ->bmap call in these aops, which may lead
>>>> to the ioctl call failure.
>>>>
>>>> Do we have any plan of adding/supporting it ?
>>>>
>>>> xfstests generic/223 covers this issue. If we are not going
>>>> to support this call for dax, we need to fix the testcase.
>>>
>>> Not supporting ->bmap is a good thing as it is hightly dangerous.
>>
>> I take this to mean "don't fix, it is another casualty of dax being
>> experimental and it won't be coming back". I can get on board with
>> that.
>>
>> Otherwise, I was about to send a series adding bmap to {xfs,ext2,ext4}_dax_ops.
>
> Frankly I'd rather see the swapfile code learn how to iomap and then we
> can get rid of bmap in xfs entirely.
Is anyone still using LILO to boot? It needed FIBMAP support to map the
kernel image for booting. I don't know if Grub needs FIBMAP support for
the early boot stages or not (it has minimal filesystem support in the
later stages), but it would be a shame if it wasn't possible to boot an
all-NVRAM system as a result of a missing ->bmap() method. Alternately,
convince the Grub folks to use FIEMAP if that is available...
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
next prev parent reply other threads:[~2018-04-17 17:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 14:40 ioctl FIBMAP for dax gone in v4.17-rc1 Xiong Zhou
2018-04-17 16:10 ` Christoph Hellwig
2018-04-17 16:53 ` Dan Williams
2018-04-17 16:57 ` Darrick J. Wong
2018-04-17 17:05 ` Dan Williams
2018-04-17 17:40 ` Andreas Dilger [this message]
2018-04-17 17:47 ` Dan Williams
2018-04-17 17:50 ` Darrick J. Wong
2018-04-17 23:34 ` Theodore Y. Ts'o
2018-04-17 23:36 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE1492A6-DF52-428C-A3CE-E91F0ACC0ADA@dilger.ca \
--to=adilger@dilger.ca \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).