From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 88BCB21309D33 for ; Mon, 12 Aug 2019 13:43:56 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id i30so1575348pfk.9 for ; Mon, 12 Aug 2019 13:41:37 -0700 (PDT) MIME-Version: 1.0 References: <20190716175021.9CA412173C@mail.kernel.org> <20190719000834.GA3228@google.com> <20190722200347.261D3218C9@mail.kernel.org> <20190722235411.06C1320840@mail.kernel.org> <20190724073125.xyzfywctrcvg6fmh@pathway.suse.cz> <20190726083148.d4gf57w2nt5k7t6n@pathway.suse.cz> <20190801211447.6D3D7206A2@mail.kernel.org> In-Reply-To: From: Brendan Higgins Date: Mon, 12 Aug 2019 13:41:24 -0700 Message-ID: Subject: Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Stephen Boyd Cc: devicetree , Peter Zijlstra , Amir Goldstein , dri-devel , Sasha Levin , Masahiro Yamada , Michael Ellerman , "open list:KERNEL SELFTEST FRAMEWORK" , shuah , Rob Herring , linux-nvdimm , Timothy Bird , Frank Rowand , "open list:DOCUMENTATION" , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Kevin Hilman , Dan Carpenter , Petr Mladek , John Ogness , linux-kbuild , Jeff Dike , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Josh Poimboeuf , kunit-dev@googlegroups.com, Theodore Ts'o , Richard Weinberger , Greg KH , Randy Dunlap , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org List-ID: On Thu, Aug 1, 2019 at 2:43 PM Brendan Higgins wrote: > > On Thu, Aug 1, 2019 at 2:14 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-08-01 11:59:57) > > > On Thu, Aug 1, 2019 at 11:55 AM Brendan Higgins > > > wrote: > > > > > > > > On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek wrote: > > > > > > > > > To be honest I do not fully understand KUnit design. I am not > > > > > completely sure how the tested code is isolated from the running > > > > > system. Namely, I do not know if the tested code shares > > > > > the same locks with the system running the test. > > > > > > > > No worries, I don't expect printk to be the hang up in those cases. It > > > > sounds like KUnit has a long way to evolve before printk is going to > > > > be a limitation. > > > > > > So Stephen, what do you think? > > > > > > Do you want me to go forward with the new kunit_assert API wrapping > > > the string_stream as I have it now? Would you prefer to punt this to a > > > later patch? Or would you prefer something else? > > > > > > > I like the struct based approach. If anything, it can be adjusted to > > make the code throw some records into a spinlock later on and delay the > > formatting of the assertion if need be. > > That's a fair point. > > > Can you resend with that > > approach? I don't think I'll have any more comments after that. I sent a new revision, v12, that incorporates the kunit_assert stuff. Let me know what you think! _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm