From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7DCD221199252 for ; Wed, 5 Dec 2018 06:45:34 -0800 (PST) Received: by mail-qt1-f196.google.com with SMTP id y20so22455893qtm.13 for ; Wed, 05 Dec 2018 06:45:34 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-2-brendanhiggins@google.com> <20181130031438.GQ4922@garbanzo.do-not-panic.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 5 Dec 2018 15:45:10 +0100 Message-ID: Subject: Re: [RFC v3 01/19] kunit: test: add KUnit test runner core List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: anton.ivanov@cambridgegreys.com Cc: Lawrence Brakmo , Brendan Higgins , dri-devel , Sasha Levin , Michael Ellerman , linux-kselftest@vger.kernel.org, Frank Rowand , Rob Herring , linux-nvdimm@lists.01.org, Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , "Bird, Timothy" , Shuah Khan , Jeff Dike , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , levinsasha928@gmail.com, kunit-dev@googlegroups.com, gregkh , Linux Kernel Mailing List , "Luis R. Rodriguez" , Daniel Vetter , Kees Cook , Joe Perches , Kevin Hilman List-ID: On Wed, Dec 5, 2018 at 2:42 PM Anton Ivanov wrote: > On 30/11/2018 03:14, Luis Chamberlain wrote: > > On Wed, Nov 28, 2018 at 11:36:18AM -0800, Brendan Higgins wrote: > > Then for the UML stuff, I think if we *really* accept that UML will > > always be a viable option we should probably consider now throwing these > > things under drivers/platform/uml/. This follows the pattern of arch > > specific drivers. Whether or not we end up with a complete userspace > > UML platform drivers predate that and are under arch/um/drivers/ > > We should either keep to current convention or consider relocating the > existing ones - having things spread in different places around the tree > is not good in the long run (UML already has a few of those under the > x86 tree, let's not increase the number). I don't mind the current location much, but if we move drivers, we should move the into the appropriate subsystems based on what they do, rather than having a new place with a mix of things. E.g. the tty drivers should all be in drivers/tty/ and the network drivers in drivers/net. To paraphrase what you said above: having tty drivers spread in different places around the tree is not good in the long run. We have long ago moved from organizing drivers by bus interface to organizing drivers by class, uml and drivers/platform are just exceptions to this rule. Arnd _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm