From: Balbir Singh <email@example.com> To: Oliver <firstname.lastname@example.org> Cc: Michael Ellerman <email@example.com>, linuxppc-dev <firstname.lastname@example.org>, Nicholas Piggin <email@example.com>, "firstname.lastname@example.org" <email@example.com> Subject: Re: [PATCH v2 2/3] powerpc/memcpy: Add memcpy_mcsafe for pmem Date: Thu, 5 Apr 2018 22:24:07 +1000 [thread overview] Message-ID: <CAKTCnzngahex_sL2raoHFuXqTxgVV7a57R9YmcT1TN-ROsFXnw@mail.gmail.com> (raw) In-Reply-To: <CAOSf1CFy0im+H368Krr2QVteAumq58CRF_Kfatyv7wvj1n4AGw@mail.gmail.com> On Thu, Apr 5, 2018 at 9:26 PM, Oliver <firstname.lastname@example.org> wrote: > On Thu, Apr 5, 2018 at 5:14 PM, Balbir Singh <email@example.com> wrote: >> The pmem infrastructure uses memcpy_mcsafe in the pmem >> layer so as to convert machine check excpetions into >> a return value on failure in case a machine check >> exception is encoutered during the memcpy. >> > > Would it be possible to move the bulk of the copyuser code into a > seperate file which can be #included once the these err macros are > defined? Anton's memcpy is pretty hairy and I don't think anyone wants > to have multiple copies of it in the tree, even in a cut down form. > I've split it out for now, in the future that might be a good thing to do. The copy_tofrom_user_power7 falls backs on __copy_tofrom_user_base to track exactly how much is left over. Adding these changes there would create a larger churn and need way more testing. I've taken this short-cut for now with a promise to fix that as the semantics of memcpy_mcsafe() change to do more accurate tracking of how much was copied over. Balbir Singh. _______________________________________________ Linux-nvdimm mailing list Linuxfirstname.lastname@example.org https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-04-05 12:24 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-05 7:14 [PATCH v2 0/3] Add support for memcpy_mcsafe Balbir Singh 2018-04-05 7:14 ` [PATCH v2 1/3] powerpc/mce: Bug fixes for MCE handling in kernel space Balbir Singh 2018-04-05 7:14 ` [PATCH v2 2/3] powerpc/memcpy: Add memcpy_mcsafe for pmem Balbir Singh 2018-04-05 11:26 ` Oliver 2018-04-05 12:24 ` Balbir Singh [this message] 2018-04-05 7:15 ` [PATCH v2 3/3] powerpc/mce: Handle memcpy_mcsafe Balbir Singh 2018-08-13 15:49 ` Reza Arbab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKTCnzngahex_sL2raoHFuXqTxgVV7a57R9YmcT1TN-ROsFXnw@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2 2/3] powerpc/memcpy: Add memcpy_mcsafe for pmem' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).