From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
To: Zhang Qilong <zhangqilong3@huawei.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH -next] ACPI: NFIT: Fix judgment of rc is '-ENXIO'
Date: Tue, 27 Oct 2020 14:59:17 +0100 [thread overview]
Message-ID: <CAM9Jb+i5ZYCVktvbmdupbM5w8J27oTEFejKL5La1sOV4iWouEA@mail.gmail.com> (raw)
In-Reply-To: <20201027134901.65045-1-zhangqilong3@huawei.com>
> Initial value of rc is '-ENXIO', and we should
> use the initial value to check it.
>
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
> drivers/acpi/nfit/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 756227837b3b..3a3c209ed3d3 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1564,7 +1564,7 @@ static ssize_t format1_show(struct device *dev,
> le16_to_cpu(nfit_dcr->dcr->code));
> break;
> }
> - if (rc != ENXIO)
> + if (rc != -ENXIO)
> break;
> }
> mutex_unlock(&acpi_desc->init_mutex);
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-10-27 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 13:49 [PATCH -next] ACPI: NFIT: Fix judgment of rc is '-ENXIO' Zhang Qilong
2020-10-27 13:59 ` Pankaj Gupta [this message]
2020-10-27 17:07 ` Verma, Vishal L
2020-10-27 18:36 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9Jb+i5ZYCVktvbmdupbM5w8J27oTEFejKL5La1sOV4iWouEA@mail.gmail.com \
--to=pankaj.gupta.linux@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=rjw@rjwysocki.net \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).