From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24B2570; Wed, 14 Jul 2021 08:44:19 +0000 (UTC) Received: by mail-ua1-f46.google.com with SMTP id c20so340386uar.12; Wed, 14 Jul 2021 01:44:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=r5k/nzvm++7I0kjlsxJbLPoLxldn2GkCJzAXrc4Q3tE=; b=gOcGreojsNbRIYOKX7kOgl/ufE/L+LqxyGLnyxvRl5Anx0Ya5qm94oYNaw6rVaK4f9 93H6AgBtNXYspn0rZJ+yFqnYfUjuwnTRFeJ/ZIuM/uTGwod8W75AVOQxJSq+P5as0atV pHp6XaiIr+JYSzM/Zh1IY+Q6jHxcyJ6zoFJKkab1K/WXPwsLJYVerZxrgYs7Ntp7xvlz TNQk23Tt2gPZugCEoqqXFwL9OCCm37+yYZvyj82H0U3cTU5mm6851CigDqHoPFv3jklV Hqzhjfp8WKC+WvkDiObZRrgP8HDnXVNZ8Al9IseEjbqXGxvpiqfNGQIAn+EcnZX/AVIU MrvQ== X-Gm-Message-State: AOAM532114POD1ju6cEg2bq3tYCtLHsnj+Zs37nO9oapq8U42jo38t31 o5aj4VUQpXibIHIKHPxZ/wHWdu5lI7DntabwEzY= X-Google-Smtp-Source: ABdhPJw+Y3tnjfY/zI+Y1qOhR0PNRzn2MQD3PHuwf/AzIRJfXjUIjP825Ll9FtnbmVsf04QAqWLG0Tq2dErAW2+m0rM= X-Received: by 2002:a9f:3f0d:: with SMTP id h13mr12412958uaj.100.1626252258156; Wed, 14 Jul 2021 01:44:18 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210713193522.1770306-1-u.kleine-koenig@pengutronix.de> <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> From: Geert Uytterhoeven Date: Wed, 14 Jul 2021 10:44:06 +0200 Message-ID: Subject: Re: [PATCH v4 5/5] bus: Make remove callback return void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Greg Kroah-Hartman , Sascha Hauer , Alexander Shishkin , Alexandre Belloni , Alexandre Bounine , Alex Dubov , Alex Elder , Alex Williamson , Alison Schofield , Allen Hubbe , Andreas Noever , Andy Gross , Arnd Bergmann , Benjamin Herrenschmidt , Benjamin Tissoires , Ben Widawsky , Bjorn Andersson , Bjorn Helgaas , Bodo Stroesser , Boris Ostrovsky , Chen-Yu Tsai , Christian Borntraeger , Cornelia Huck , Cristian Marussi , Dan Williams , Dave Jiang , "David S. Miller" , David Woodhouse , Dexuan Cui , Dmitry Torokhov , Dominik Brodowski , Finn Thain , Florian Fainelli , Frank Li , Geoff Levand , Haiyang Zhang , Hannes Reinecke , Hans de Goede , Harald Freudenberger , Heikki Krogerus , Heiko Carstens , Helge Deller , Ira Weiny , Jakub Kicinski , "James E.J. Bottomley" , Jaroslav Kysela , Jason Wang , Jens Taprogge , Jernej Skrabec , Jiri Kosina , Jiri Slaby , Joey Pabalan , Johan Hovold , Johannes Berg , Johannes Thumshirn , Jon Mason , Juergen Gross , Julien Grall , Kai-Heng Feng , Kirti Wankhede , Kishon Vijay Abraham I , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , "K. Y. Srinivasan" , Lee Jones , Len Brown , Lorenzo Pieralisi , Manohar Vanga , Marc Zyngier , Mark Brown , Mark Gross , "Martin K. Petersen" , Martyn Welch , Mathieu Poirier , Matt Porter , Mauro Carvalho Chehab , Maxime Ripard , Maximilian Luz , Maxim Levitsky , Michael Buesch , Michael Ellerman , Michael Jamet , "Michael S. Tsirkin" , Mika Westerberg , Mike Christie , Moritz Fischer , Ohad Ben-Cohen , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Paul Mackerras , Peter Oberparleiter , "Rafael J. Wysocki" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rich Felker , Rikard Falkeborn , Rob Herring , Russell King , "Russell King (Oracle)" , Samuel Holland , Samuel Iglesias Gonsalvez , SeongJae Park , Srinivas Kandagatla , Srinivas Pandruvada , Stefano Stabellini , Stefan Richter , Stephen Boyd , Stephen Hemminger , Sudeep Holla , Sven Van Asbroeck , Takashi Iwai , Thomas Bogendoerfer , Thorsten Scherer , Tomas Winkler , Tom Rix , Tyrel Datwyler , Ulf Hansson , Vasily Gorbik , Vineeth Vijayan , Vinod Koul , Vishal Verma , Wei Liu , William Breathitt Gray , Wolfram Sang , Wu Hao , Yehezkel Bernat , Yoshinori Sato , YueHaibing , Yufen Yu , alsa-devel@alsa-project.org, dmaengine@vger.kernel.org, greybus-dev@lists.linaro.org, industrypack-devel@lists.sourceforge.net, kvm@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fpga@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-ntb@googlegroups.com, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, linux-sh@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, nvdimm@lists.linux.dev, platform-driver-x86@vger.kernel.org, sparclinux@vger.kernel.org, target-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Johannes Thumshirn , "Rafael J . Wysocki" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 13, 2021 at 9:35 PM Uwe Kleine-K=C3=B6nig wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > drivers/zorro/zorro-driver.c | 3 +-- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds