nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Oliver <oohall@gmail.com>
To: Balbir Singh <bsingharora@gmail.com>
Cc: Device Tree <devicetree@vger.kernel.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [RESEND v2 3/4] doc/devicetree: Persistent memory region bindings
Date: Thu, 5 Apr 2018 00:04:01 +1000	[thread overview]
Message-ID: <CAOSf1CGdKU4zQQauqo3UoNvKnKDMHteAEtsMWVtTG7T01csMbg@mail.gmail.com> (raw)
In-Reply-To: <20180404220750.0436bbe1@gmail.com>

On Wed, Apr 4, 2018 at 10:07 PM, Balbir Singh <bsingharora@gmail.com> wrote:
> On Tue, 3 Apr 2018 10:37:51 -0700
> Dan Williams <dan.j.williams@intel.com> wrote:
>
>> On Tue, Apr 3, 2018 at 7:24 AM, Oliver O'Halloran <oohall@gmail.com> wrote:
>> > Add device-tree binding documentation for the nvdimm region driver.
>> >
>> > Cc: devicetree@vger.kernel.org
>> > Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
>> > ---
>> > v2: Changed name from nvdimm-region to pmem-region.
>> >     Cleaned up the example binding and fixed the overlapping regions.
>> >     Added support for multiple regions in a single reg.
>> > ---
>> >  .../devicetree/bindings/pmem/pmem-region.txt       | 80 ++++++++++++++++++++++
>> >  MAINTAINERS                                        |  1 +
>> >  2 files changed, 81 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/pmem/pmem-region.txt
>>
>> Device-tree folks, does this look, ok?
>>
>> Oliver, is there any concept of a management interface to the
>> device(s) backing these regions? libnvdimm calls these "nmem" devices
>> and support operations like health status and namespace label
>> management.

It's something I'm planning on implementing as soon as someone gives
me some hardware that isn't hacked up lab crap. I'm posting this
version with just regions since people have been asking for something
in upstream even if it's not fully featured.

Grumbling aside, the plan is to have separate drivers for the DIMM
type. Discovering DIMM devices happens via the normal discovery
mechanisms (e.g. an NVDIMM supporting the JEDEC interface is an I2C
device) and when binding to a specific DIMM device it registers a DIMM
descriptor structure and a ndctl implementation for that DIMM type
with of_pmem. When of_pmem binds to a region it can plug everything
into the region specific bus. There's a few details to work out, but I
think it's a reasonable approach.

> We would need a way to have nmem and pmem-regions find each other. Since we
> don't have the ACPI abstractions, the nmem region would need to add the
> ability for a driver to have a phandle to the interleaving and nmem properties.
>
> I guess that would be a separate driver, that would manage the nmem devices
> and there would be a way to relate the pmem and nmems. Oliver?

Yes, that's the plan.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2018-04-04 14:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 14:24 [RESEND v2 1/4] libnvdimm: Add of_node to region and bus descriptors Oliver O'Halloran
2018-04-03 14:24 ` [RESEND v2 2/4] libnvdimm: Add device-tree based driver Oliver O'Halloran
2018-04-03 17:34   ` Dan Williams
2018-04-03 14:24 ` [RESEND v2 3/4] doc/devicetree: Persistent memory region bindings Oliver O'Halloran
2018-04-03 17:37   ` Dan Williams
2018-04-04 12:07     ` Balbir Singh
2018-04-04 14:04       ` Oliver [this message]
2018-04-04 14:21         ` Dan Williams
2018-04-05  4:43           ` Balbir Singh
2018-04-05 11:34           ` Oliver
2018-04-05 12:11             ` Michael Ellerman
2018-04-05 12:43               ` Oliver
2018-04-05 14:43                 ` Dan Williams
2018-04-06  2:14                   ` Oliver
2018-04-06  2:25                     ` Dan Williams
2018-04-06  3:57                       ` Benjamin Herrenschmidt
2018-04-03 14:24 ` [RESEND v2 4/4] powerpc/powernv: Create platform devs for nvdimm buses Oliver O'Halloran
2018-04-04 12:20   ` Balbir Singh
2018-04-04 11:30 ` [RESEND v2 1/4] libnvdimm: Add of_node to region and bus descriptors Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOSf1CGdKU4zQQauqo3UoNvKnKDMHteAEtsMWVtTG7T01csMbg@mail.gmail.com \
    --to=oohall@gmail.com \
    --cc=bsingharora@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).