From: Dan Williams <dan.j.williams@intel.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
Mike Snitzer <snitzer@redhat.com>,
linux-s390 <linux-s390@vger.kernel.org>,
linux-erofs@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
linux-xfs <linux-xfs@vger.kernel.org>,
device-mapper development <dm-devel@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Ira Weiny <ira.weiny@intel.com>
Subject: Re: [dm-devel] [PATCH 07/11] dax: remove dax_capable
Date: Wed, 27 Oct 2021 17:20:40 -0700 [thread overview]
Message-ID: <CAPcyv4g0yC3S8X6_DPtSjgFu3XFOHwu1KDy1HQP9eWk-EnDaxA@mail.gmail.com> (raw)
In-Reply-To: <20211019154447.GL24282@magnolia>
On Tue, Oct 19, 2021 at 8:45 AM Darrick J. Wong <djwong@kernel.org> wrote:
>
> On Mon, Oct 18, 2021 at 06:40:50AM +0200, Christoph Hellwig wrote:
> > Just open code the block size and dax_dev == NULL checks in the callers.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > drivers/dax/super.c | 36 ------------------------------------
> > drivers/md/dm-table.c | 22 +++++++++++-----------
> > drivers/md/dm.c | 21 ---------------------
> > drivers/md/dm.h | 4 ----
> > drivers/nvdimm/pmem.c | 1 -
> > drivers/s390/block/dcssblk.c | 1 -
> > fs/erofs/super.c | 11 +++++++----
> > fs/ext2/super.c | 6 ++++--
> > fs/ext4/super.c | 9 ++++++---
> > fs/xfs/xfs_super.c | 21 ++++++++-------------
> > include/linux/dax.h | 14 --------------
> > 11 files changed, 36 insertions(+), 110 deletions(-)
> >
[..] if (ext4_has_feature_inline_data(sb)) {
> > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > index d07020a8eb9e3..163ceafbd8fd2 100644
> > --- a/fs/xfs/xfs_super.c
> > +++ b/fs/xfs/xfs_super.c
[..]
> > + if (mp->m_super->s_blocksize != PAGE_SIZE) {
> > + xfs_alert(mp,
> > + "DAX not supported for blocksize. Turning off DAX.\n");
>
> Newlines aren't needed at the end of extX_msg/xfs_alert format strings.
Thanks Darrick, I fixed those up.
next prev parent reply other threads:[~2021-10-28 0:20 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 4:40 futher decouple DAX from block devices Christoph Hellwig
2021-10-18 4:40 ` [PATCH 01/11] dm: make the DAX support dependend on CONFIG_FS_DAX Christoph Hellwig
2021-10-27 20:53 ` Dan Williams
2021-11-01 16:12 ` Mike Snitzer
2021-10-18 4:40 ` [PATCH 02/11] dax: remove CONFIG_DAX_DRIVER Christoph Hellwig
2021-10-27 20:54 ` Dan Williams
2021-10-18 4:40 ` [PATCH 03/11] dax: simplify the dax_device <-> gendisk association Christoph Hellwig
2021-10-27 22:03 ` Dan Williams
2021-10-29 4:57 ` Ira Weiny
2021-11-01 16:28 ` Mike Snitzer
2021-10-18 4:40 ` [PATCH 04/11] dax: remove the pgmap sanity checks in generic_fsdax_supported Christoph Hellwig
2021-10-27 23:02 ` Dan Williams
2021-10-18 4:40 ` [PATCH 05/11] dax: move the partition alignment check into fs_dax_get_by_bdev Christoph Hellwig
2021-10-27 23:07 ` Dan Williams
2021-10-18 4:40 ` [PATCH 06/11] xfs: factor out a xfs_setup_dax helper Christoph Hellwig
2021-10-18 16:43 ` Darrick J. Wong
2021-10-19 7:23 ` Christoph Hellwig
2021-10-27 23:37 ` Dan Williams
2021-10-18 4:40 ` [PATCH 07/11] dax: remove dax_capable Christoph Hellwig
2021-10-18 12:25 ` Gao Xiang
2021-10-19 15:44 ` [dm-devel] " Darrick J. Wong
2021-10-28 0:20 ` Dan Williams [this message]
2021-10-28 0:16 ` Dan Williams
2021-11-01 16:17 ` Mike Snitzer
2021-10-18 4:40 ` [PATCH 08/11] dm-linear: add a linear_dax_pgoff helper Christoph Hellwig
2021-10-28 1:32 ` Dan Williams
2021-11-01 16:18 ` Mike Snitzer
2021-10-18 4:40 ` [PATCH 09/11] dm-log-writes: add a log_writes_dax_pgoff helper Christoph Hellwig
2021-10-28 1:36 ` Dan Williams
2021-11-01 16:19 ` Mike Snitzer
2021-10-18 4:40 ` [PATCH 10/11] dm-stripe: add a stripe_dax_pgoff helper Christoph Hellwig
2021-10-28 1:41 ` Dan Williams
2021-11-01 16:21 ` Mike Snitzer
2021-10-18 4:40 ` [PATCH 11/11] dax: move bdev_dax_pgoff to fs/dax.c Christoph Hellwig
2021-10-28 1:44 ` Dan Williams
2021-10-27 20:46 ` futher decouple DAX from block devices Dan Williams
2021-10-28 23:51 ` Stephen Rothwell
2021-10-29 15:42 ` Dan Williams
2021-10-29 15:55 ` Darrick J. Wong
2021-10-29 16:16 ` Dan Williams
2021-11-03 17:59 ` Eric Sandeen
2021-11-04 8:17 ` Christoph Hellwig
2021-11-04 17:34 ` Darrick J. Wong
2021-11-04 17:35 ` Christoph Hellwig
2021-11-04 18:10 ` Dan Williams
2021-11-04 19:04 ` Darrick J. Wong
2021-11-05 3:09 ` Theodore Ts'o
2021-11-05 3:30 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4g0yC3S8X6_DPtSjgFu3XFOHwu1KDy1HQP9eWk-EnDaxA@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=snitzer@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).