From: Dan Williams <dan.j.williams@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Luck, Tony" <tony.luck@intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
stable <stable@vger.kernel.org>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it
Date: Tue, 6 Nov 2018 10:02:46 -0800 [thread overview]
Message-ID: <CAPcyv4g=7HZjxQCdA+fYAacEeRPwcuONGiDUZPunL=_V4jf3qQ@mail.gmail.com> (raw)
In-Reply-To: <20181106175341.GK13712@zn.tnic>
On Tue, Nov 6, 2018 at 9:53 AM Borislav Petkov <bp@alien8.de> wrote:
>
> On Tue, Nov 06, 2018 at 08:20:38AM -0800, Dan Williams wrote:
> > I recommended the split so the fixes can be tracked and / or reverted
> > independently if they cause problems.
>
> Do you have anything concrete in mind that might go wrong or just a
> general cautiousness?
Just general cautiousness, I'm not opposed to squashing them.
> Or do you think the hw might not spit what mce_usable_address() is
> checking for, for NVDIMM MCEs, so that you'd like to be able to revert
> that second patch?
mce_usable_address() should not have any sensitivity to NVDIMM vs DRAM MCEs.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-11-06 18:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 0:37 [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks Vishal Verma
2018-10-26 0:37 ` [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it Vishal Verma
2018-11-06 14:51 ` Borislav Petkov
2018-11-06 16:20 ` Dan Williams
2018-11-06 17:53 ` Borislav Petkov
2018-11-06 18:02 ` Dan Williams [this message]
2018-11-06 18:07 ` Borislav Petkov
2019-02-20 18:59 ` [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks Jeff Moyer
2019-02-20 19:18 ` Borislav Petkov
2019-02-20 19:26 ` Jeff Moyer
2019-02-20 19:39 ` Borislav Petkov
2019-02-20 19:40 ` Dan Williams
2019-02-20 19:47 ` Borislav Petkov
2019-02-21 16:11 ` Jeff Moyer
2019-02-21 17:09 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4g=7HZjxQCdA+fYAacEeRPwcuONGiDUZPunL=_V4jf3qQ@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).