From: Dan Williams <dan.j.williams@intel.com>
To: "Qi, Fuli" <qi.fuli@jp.fujitsu.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v6 2/4] ndctl, monitor: add ndctl monitor daemon
Date: Thu, 31 May 2018 15:23:46 -0700 [thread overview]
Message-ID: <CAPcyv4gO6HDXb6ZG4M6NJcvc9CCTC9nE5ibr6cg5kF==OqvTPw@mail.gmail.com> (raw)
In-Reply-To: <0DEDF3B159719A448A49EF0E7B11E3222766DC25@g01jpexmbkw01>
On Fri, May 25, 2018 at 1:49 AM, Qi, Fuli <qi.fuli@jp.fujitsu.com> wrote:
>> As mentioned above this function seems to assume that the only DIMM events to
>> send are DIMM health events. It's ok to save other object monitoring to a later patch,
>> but let's at least support DIMM health
>> events:
>>
>> dimm-spares-remaining
>> dimm-media-temperature
>> dimm-controller-temperature
>> dimm-health-state
>>
>> ...and DIMM detected events:
>>
>> dimm-unclean-shutdown
>> dimm-detected
>>
>> There should be an event type included in the json. Along with 'timestamp' and 'pid'
>> I think we need an 'event' field so that consumer code can make assumptions about
>> the format of the event record. I think 'dimm-health' and 'dimm-detect' are the only
>> event record types we need to support in this initial version.
>>
>
> Hi, Dan
>
> I would like to confirm whether my understanding of the feature in each dimm-event is right or not.
> a) dimm-spares-remaining
> Checking the Spare Block Remaining Trip in Alarm Trips, if set then the notification is dimm-spares-remaining.
Yes.
> b) dimm-media-temperature
> Checking the NVDIMM Media Temperature Trip in Alarm Trips, if set then the notification is dimm-media-temperature.
Yes.
> c) dimm-controller-temperature
> Checking the NVDIMM Controller Temperature Trip in Alarm Trips, if set then the notification is dimm-controller-temperature.
Yes.
> d) dimm-health-state
> Checking the Health Status, if changed then the notification is dimm-health-state.
Yes.
> e) dimm-unclean-shutdown
> Checking the Last Shutdown Status, if changed then the notification is dimm-unclean-shutdown.
Yes.
> f) dimm-detected
> Checking the UUID of DIMM, if changed then the notification is dimm-detected.
No, this would fire for each DIMM detected when the daemon starts up,
and for any future DIMM that is hot plugged into the system. The
notification of hotplugged DIMM devices would be a uevent. We can save
this notification for later as it is different from the
'health_event_fd' that these other notifications are communicated.
> Is there a possibility that a notification contains multiple dimm-events?
Yes, we may only get 1 notification from the kernel, but all of these
items might have changed / tripped.
>
> Should I need to turn off the event alarm after the notification logged?
No, if the kernel continues to send events then the monitor should log them.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-05-31 22:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 5:09 [PATCH v6 0/4] ndctl, monitor: add ndctl monitor daemon QI Fuli
2018-05-07 5:09 ` [PATCH v6 1/4] ndctl, util: add OPTION_FILENAME to parse_opt_type QI Fuli
2018-05-11 16:42 ` Dan Williams
2018-05-16 2:42 ` Qi, Fuli
2018-06-12 22:45 ` Verma, Vishal L
2018-06-12 23:51 ` Qi, Fuli
2018-05-07 5:09 ` [PATCH v6 2/4] ndctl, monitor: add ndctl monitor daemon QI Fuli
2018-05-11 18:45 ` Dan Williams
2018-05-15 8:32 ` Qi, Fuli
2018-05-15 17:07 ` Dan Williams
2018-05-16 2:44 ` Qi, Fuli
2018-05-25 8:49 ` Qi, Fuli
2018-05-31 22:23 ` Dan Williams [this message]
2018-05-07 5:09 ` [PATCH v6 3/4] ndctl, monitor: add default configuration file QI Fuli
2018-05-07 5:09 ` [PATCH v6 4/4] ndctl, monitor: add the unit file of systemd for ndctl-monitor service QI Fuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4gO6HDXb6ZG4M6NJcvc9CCTC9nE5ibr6cg5kF==OqvTPw@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=qi.fuli@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).