From: Dan Williams <dan.j.williams@intel.com>
To: QI Fuli <qi.fuli@jp.fujitsu.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH v2] ndctl, test: add a new unit test for monitor
Date: Fri, 6 Jul 2018 20:43:01 -0700 [thread overview]
Message-ID: <CAPcyv4h36Nr7=_ZS8zT9pO-z0sEy2DUXP67-TLwDpO+VP+cvtQ@mail.gmail.com> (raw)
In-Reply-To: <5B401C00.6010100@jp.fujitsu.com>
On Fri, Jul 6, 2018 at 6:48 PM, QI Fuli <qi.fuli@jp.fujitsu.com> wrote:
> Hi Masa,
>
> Thank you for your comments.
>
> On 7/7/2018 12:08 AM, Masayoshi Mizuma wrote:
>>
>> Hi Qi,
>>
>> On 07/06/2018 01:22 AM, QI Fuli wrote:
>>>
>>> Add a new unit test to test the following options of the monitor command.
>>> --dimm
>>> --bus
>>> --region
>>> --namespace
>>> --logfile
>>> --config-file
>>>
>>> Based-on-patch-by: Yasunori Goto <y-goto@jp.fujitsu.com>
>>> Acked-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
>>
>> I think this Acked-by is wrong because I'm not a maintainer :-)
>
> I'm sorry for this mistake.
I'm perfectly fine to take reviewed-by's and acked-by's from
non-maintainers. In fact I'd prefer to have more. I'm sure Vishal
feels the same.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-07-07 3:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 5:22 [ndctl PATCH v2] ndctl, test: add a new unit test for monitor QI Fuli
2018-07-06 15:08 ` Masayoshi Mizuma
2018-07-07 1:48 ` QI Fuli
2018-07-07 3:43 ` Dan Williams [this message]
2018-07-07 6:21 ` Verma, Vishal L
2018-07-07 3:57 ` Dan Williams
2018-07-07 4:20 ` Qi, Fuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4h36Nr7=_ZS8zT9pO-z0sEy2DUXP67-TLwDpO+VP+cvtQ@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=qi.fuli@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).