From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82C683FC1 for ; Fri, 3 Sep 2021 03:58:33 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id v123so3293879pfb.11 for ; Thu, 02 Sep 2021 20:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4wOalAePuAJnThsQpwJBROsDRanxKLhv6aAjQVKpLCk=; b=LS+dmgpAD636OwNI7DMrkDYpAhR1yT1A3WcKYbfo2x+uchmZNT4sEWaqsTJU6AeKVN ouvdDOYe0d+8ohickpONYg2BYV/uv3tckR8eszW9wGyRkr28nYA25Vc4oqXtAQrHMAjD e+tCOxpaHGTbry1srsJH0VR2PMijUHV2KAy5+KsxORGM9kEj6ftr5MVOU7S//QlLUGhr 6dPK+K7jtqybJzipkadWrg/t7w2Fnc0LtuGrkmOedIfgmch/6+RaH7kEi/bEKzYG0+Em 93vHzlKjrHotec9qCZkCTMcnbTNtBQOZuL7aBkYBJMNU7JHlwoFXNHaoMBVl9sCn+eOd Mz9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4wOalAePuAJnThsQpwJBROsDRanxKLhv6aAjQVKpLCk=; b=cBVhFd/AjKI4Jfx1WeTOitwz3tmkV0AHycvekdEYclZuBNw67DOJTAtkTtFOqT2pRb I59JF2/zymytZv7FRXXY7tuZzLq90g1pvOivMooqeTCtKyPG+PpQdcWx61XrAxr6hQxb y2/+NzN7WByJeP5596q2s0sQYTolpBvRG1IMb54isE1zs+UJBZPem1ygzGPrUtnBYg/v oAb7OGYuzys6/D3JLjyI0rxoDxXShJJYWHVHpH1jj2l5g3lNFi9zDb1NuDR/EUmWAEV8 FeOcXUtc0cPFT0jLN04aqelBW+RlONO7rkJ7tVToCZ4T7FWveLzf/Iu6nqurSI9Zz5ns /zyw== X-Gm-Message-State: AOAM532Jqr+QQ8EViZFPE6AHKREz2+aqVIZJFIEYlpk95gYLaIEz4K2r mK1OJgPc3Ociy2ir3r0jMme69+TzG52jajZAybgN7A== X-Google-Smtp-Source: ABdhPJzGRoF8cOmILH2aN/M/bwig3fIeWC6Qc+Z0Gjm/st5g5Ld7mmbaGMDL7QVzHdH2bf7VLZvwE3mtAwMVRkYy7j0= X-Received: by 2002:a65:47c6:: with SMTP id f6mr1686451pgs.450.1630641512751; Thu, 02 Sep 2021 20:58:32 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <162982112370.1124374.2020303588105269226.stgit@dwillia2-desk3.amr.corp.intel.com> <162982119604.1124374.8364301519543316156.stgit@dwillia2-desk3.amr.corp.intel.com> <20210902173602.00000272@Huawei.com> <20210902174138.000064a7@Huawei.com> In-Reply-To: <20210902174138.000064a7@Huawei.com> From: Dan Williams Date: Thu, 2 Sep 2021 20:58:22 -0700 Message-ID: Subject: Re: [PATCH v3 13/28] libnvdimm/label: Define CXL region labels To: Jonathan Cameron Cc: linux-cxl@vger.kernel.org, Vishal L Verma , "Schofield, Alison" , Linux NVDIMM , "Weiny, Ira" , Ben Widawsky Content-Type: text/plain; charset="UTF-8" On Thu, Sep 2, 2021 at 9:41 AM Jonathan Cameron wrote: > > On Thu, 2 Sep 2021 17:36:02 +0100 > Jonathan Cameron wrote: > > > On Tue, 24 Aug 2021 09:06:36 -0700 > > Dan Williams wrote: > > > > > Add a definition of the CXL 2.0 region label format. Note this is done > > > as a separate patch to make the next patch that adds namespace label > > > support easier to read. > > > > > > Reported-by: Jonathan Cameron > > > Signed-off-by: Dan Williams > > FWIW > > Reviewed-by: Jonathan Cameron > Oops. Just noticed something below that needs fixing, so keep > that RB with the missing docs fixed. > > > > > > --- > > > drivers/nvdimm/label.h | 30 ++++++++++++++++++++++++++++++ > > > 1 file changed, 30 insertions(+) > > > > > > diff --git a/drivers/nvdimm/label.h b/drivers/nvdimm/label.h > > > index 31f94fad7b92..76ecd0347dc2 100644 > > > --- a/drivers/nvdimm/label.h > > > +++ b/drivers/nvdimm/label.h > > > @@ -65,6 +65,36 @@ struct nd_namespace_index { > > > u8 free[]; > > > }; > > > > > > +/** > > > + * struct cxl_region_label - CXL 2.0 Table 211 > > > + * @type: uuid identifying this label format (region) > > > + * @uuid: uuid for the region this label describes > > > + * @flags: NSLABEL_FLAG_UPDATING (all other flags reserved) > > nlabel docs missing here. > > > > + * @position: this label's position in the set > > > + * @dpa: start address in device-local capacity for this label > > > + * @rawsize: size of this label's contribution to region > > > + * @hpa: mandatory system physical address to map this region > > > + * @slot: slot id of this label in label area > > > + * @ig: interleave granularity (1 << @ig) * 256 bytes > > > + * @align: alignment in SZ_256M blocks > > Probably need to add docs for reserved to suppress warnings > from the kernel-doc build (unless it's clever about things called reserved?) Nope, it complains about @reserved not being documented. There's some legacy kernel-doc escapes in this file, so I fix those up in a separate patch before this one.