From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
linux-block@vger.kernel.org,
Linux NVDIMM <nvdimm@lists.linux.dev>
Subject: Re: [PATCH 1/3] nvdimm/pmem: fix creating the dax group
Date: Mon, 20 Sep 2021 16:09:13 -0700 [thread overview]
Message-ID: <CAPcyv4hVR9J6M+0-KcnmNeRywvF4CobyEtKA9repq9ivtKy77Q@mail.gmail.com> (raw)
In-Reply-To: <20210920072726.1159572-2-hch@lst.de>
On Mon, Sep 20, 2021 at 12:29 AM Christoph Hellwig <hch@lst.de> wrote:
>
> The recent block layer refactoring broke the way how the pmem driver
> abused device_add_disk. Fix this by properly passing the attribute groups
> to device_add_disk.
>
> Fixes: 52b85909f85d ("block: fold register_disk into device_add_disk")
This also fixes the the way the pmem driver abused device_add_disk(),
so perhaps add:
Fixes: fef912bf860e ("block: genhd: add 'groups' argument to device_add_disk")
...as well. It's not a stable fix as this is only a cosmetic fixup
until the most recent refactoring turned it into a bug.
Either way, you can add:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2021-09-20 23:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 7:27 fix a dax/block device attribute registration regression Christoph Hellwig
2021-09-20 7:27 ` [PATCH 1/3] nvdimm/pmem: fix creating the dax group Christoph Hellwig
2021-09-20 22:52 ` Ira Weiny
2021-09-20 23:09 ` Dan Williams [this message]
2021-09-20 7:27 ` [PATCH 2/3] nvdimm/pmem: move dax_attribute_group from dax to pmem Christoph Hellwig
2021-09-20 18:00 ` kernel test robot
2021-09-20 23:29 ` Dan Williams
2021-09-20 22:51 ` Ira Weiny
2021-09-20 23:36 ` Dan Williams
2021-09-20 23:37 ` Dan Williams
2021-09-20 7:27 ` [PATCH 3/3] block: warn if ->groups is set when calling add_disk Christoph Hellwig
2021-09-20 22:52 ` Ira Weiny
2021-09-20 23:50 ` Dan Williams
2021-09-21 6:32 ` Christoph Hellwig
2021-09-22 17:34 dax_supported() related cleanups v2 Christoph Hellwig
2021-09-22 17:34 ` [PATCH 1/3] nvdimm/pmem: fix creating the dax group Christoph Hellwig
2021-09-22 18:33 fix a dax/block device attribute registration regression Christoph Hellwig
2021-09-22 18:33 ` [PATCH 1/3] nvdimm/pmem: fix creating the dax group Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hVR9J6M+0-KcnmNeRywvF4CobyEtKA9repq9ivtKy77Q@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=axboe@kernel.dk \
--cc=dave.jiang@intel.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).