nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Vishal L Verma <vishal.l.verma@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH 5/5] util/json: add a util_namespace_badblocks_to_json() helper
Date: Tue, 2 Oct 2018 18:58:32 -0700	[thread overview]
Message-ID: <CAPcyv4hkoWbKXT7HcM6AhOkE-u6QEKoS6ppdrqJUcB2b8yjoTQ@mail.gmail.com> (raw)
In-Reply-To: <20181002033140.21295-5-vishal.l.verma@intel.com>

On Mon, Oct 1, 2018 at 8:38 PM Vishal Verma <vishal.l.verma@intel.com> wrote:
> When ndctl list --media-errors is invoked, we rely upon the 'region'
> badblocks provided by the kernel, and reference them against the
> namespace start to report namespace badblocks. This can fail for
> non-root users, as the region and namespace resource information is
> root-only. However the kernel also provides block-device badblocks
> information in sysfs, and that is world readable. Provide a new helper
> to retrieve this information, and use it as a fallback when the region
> based badblocks are unavailable.
> Note that when falling back to the namespace based badblocks, we are
> unable to retrieve the DIMM on which the badblocks are present, since we
> still need root privileges for both getting the resource information,
> and for the address translation command.
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Linux-nvdimm mailing list

      reply	other threads:[~2018-10-03  1:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02  3:31 [ndctl PATCH 1/5] ndctl, lib: refactor badblocks retrieval routines Vishal Verma
2018-10-02  3:31 ` [ndctl PATCH 2/5] ndctl, lib: add APIs for retrieving namespace badblocks Vishal Verma
2018-10-02  3:31 ` [ndctl PATCH 3/5] util/json: fix an error check for region resource Vishal Verma
2018-10-03  1:47   ` Dan Williams
2018-10-02  3:31 ` [ndctl PATCH 4/5] util/json: consolidate check for the UTIL_JSON_MEDIA_ERRORS flag Vishal Verma
2018-10-03  1:52   ` Dan Williams
2018-10-02  3:31 ` [ndctl PATCH 5/5] util/json: add a util_namespace_badblocks_to_json() helper Vishal Verma
2018-10-03  1:58   ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPcyv4hkoWbKXT7HcM6AhOkE-u6QEKoS6ppdrqJUcB2b8yjoTQ@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=vishal.l.verma@intel.com \
    --subject='Re: [ndctl PATCH 5/5] util/json: add a util_namespace_badblocks_to_json() helper' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).